[v2,5/5] dt-bindings: at24: add bindings for Rohm BR24T01

Message ID 1517240748-14780-6-git-send-email-ulrich.hecht+renesas@gmail.com
State New
Headers show
Series
  • R-Car D3 (r8a77995) I2C integration
Related show

Commit Message

Ulrich Hecht Jan. 29, 2018, 3:45 p.m.
Both manufacturer and name variant.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven Jan. 29, 2018, 4:06 p.m. | #1
On Mon, Jan 29, 2018 at 4:45 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Both manufacturer and name variant.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Wolfram Sang Jan. 30, 2018, 10:44 a.m. | #2
On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
> Both manufacturer and name variant.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Bartosz Golaszewski Feb. 2, 2018, 9:02 a.m. | #3
2018-01-30 11:44 GMT+01:00 Wolfram Sang <wsa@the-dreams.de>:
> On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
>> Both manufacturer and name variant.
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>

Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
Rob Herring Feb. 5, 2018, 6:07 a.m. | #4
On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
> Both manufacturer and name variant.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 1812c84..dd29937 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -40,6 +40,7 @@ Required properties:
>                  "microchip",
>                  "ramtron",
>                  "renesas",
> +                "rohm",

This is going to comflict with a patch sorting these IIRC. So they 
should go thru the same tree.

>                  "nxp",
>                  "st",
>  
> @@ -47,6 +48,7 @@ Required properties:
>                  variants of the above. Known such exceptions are listed below:
>  
>                  "renesas,r1ex24002" - the fallback is "atmel,24c02"
> +                "rohm,br24t01" - the fallback is "atmel,24c01"
>  
>    - reg: The I2C address of the EEPROM.
>  
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartosz Golaszewski Feb. 5, 2018, 7:56 a.m. | #5
2018-02-05 7:07 GMT+01:00 Rob Herring <robh@kernel.org>:
> On Mon, Jan 29, 2018 at 04:45:48PM +0100, Ulrich Hecht wrote:
>> Both manufacturer and name variant.
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
>>
>> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
>> index 1812c84..dd29937 100644
>> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
>> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
>> @@ -40,6 +40,7 @@ Required properties:
>>                  "microchip",
>>                  "ramtron",
>>                  "renesas",
>> +                "rohm",
>
> This is going to comflict with a patch sorting these IIRC. So they
> should go thru the same tree.
>
>>                  "nxp",
>>                  "st",
>>
>> @@ -47,6 +48,7 @@ Required properties:
>>                  variants of the above. Known such exceptions are listed below:
>>
>>                  "renesas,r1ex24002" - the fallback is "atmel,24c02"
>> +                "rohm,br24t01" - the fallback is "atmel,24c01"
>>
>>    - reg: The I2C address of the EEPROM.
>>
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

AT24 patches go through Wolfram's tree, but since he already sent his
PR for 4.16, I can pick them up for 4.17 (except for Peter's sorting
patch which should go in after 4.16-rc1).

Thanks,
Bartosz

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 1812c84..dd29937 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -40,6 +40,7 @@  Required properties:
                 "microchip",
                 "ramtron",
                 "renesas",
+                "rohm",
                 "nxp",
                 "st",
 
@@ -47,6 +48,7 @@  Required properties:
                 variants of the above. Known such exceptions are listed below:
 
                 "renesas,r1ex24002" - the fallback is "atmel,24c02"
+                "rohm,br24t01" - the fallback is "atmel,24c01"
 
   - reg: The I2C address of the EEPROM.