From patchwork Mon Mar 14 07:46:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huzaifa Sidhpurwala X-Patchwork-Id: 86684 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8AD33B6EEC for ; Mon, 14 Mar 2011 18:46:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546Ab1CNHqO (ORCPT ); Mon, 14 Mar 2011 03:46:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127Ab1CNHqN (ORCPT ); Mon, 14 Mar 2011 03:46:13 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2E7kCZa019306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Mar 2011 03:46:12 -0400 Received: from babylon.pnq.redhat.com (babylon.pnq.redhat.com [10.65.192.182]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2E7kBFs031000; Mon, 14 Mar 2011 03:46:12 -0400 Received: by babylon.pnq.redhat.com (Postfix, from userid 500) id C768A202CC; Mon, 14 Mar 2011 13:16:10 +0530 (IST) From: huzaifas@redhat.com To: netdev@vger.kernel.org Cc: leitao@linux.vnet.ibm.com, Huzaifa Sidhpurwala Subject: [PATCH] Fix possible null pointer dereference in ehea_qmr.c Date: Mon, 14 Mar 2011 13:16:04 +0530 Message-Id: <1300088764-9330-1-git-send-email-huzaifas@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Huzaifa Sidhpurwala If queue is zero, dont reference it Signed-off-by: Huzaifa Sidhpurwala --- drivers/net/ehea/ehea_qmr.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ehea/ehea_qmr.c b/drivers/net/ehea/ehea_qmr.c index cd44bb8..fd0815d 100644 --- a/drivers/net/ehea/ehea_qmr.c +++ b/drivers/net/ehea/ehea_qmr.c @@ -106,12 +106,13 @@ out_nomem: static void hw_queue_dtor(struct hw_queue *queue) { - int pages_per_kpage = PAGE_SIZE / queue->pagesize; + int pages_per_kpage; int i, nr_pages; if (!queue || !queue->queue_pages) return; + pages_per_kpage = PAGE_SIZE / queue->pagesize; nr_pages = queue->queue_length / queue->pagesize; for (i = 0; i < nr_pages; i += pages_per_kpage)