| Message ID | 1517083050-9079-1-git-send-email-trini@konsulko.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] usb: Remove unused hcd_name variable | expand |
On 01/27/2018 08:57 PM, Tom Rini wrote: > Both the isp116x-hcd and r8a66597-hcd drivers have an unused hcd_name > variable, drop. isp116x-hcd also defines an unused DRIVER_VERSION, so > drop that while in here. > > Cc: Marek Vasut <marex@denx.de> (maintainer:USB) > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > drivers/usb/host/isp116x-hcd.c | 3 --- > drivers/usb/host/r8a66597-hcd.c | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c > index 32874d73de84..d1d2d6bd9599 100644 > --- a/drivers/usb/host/isp116x-hcd.c > +++ b/drivers/usb/host/isp116x-hcd.c Does anyone actually use this driver ? I cannot find anyone, so just remove it. > @@ -92,9 +92,6 @@ > > #include "isp116x.h" > > -#define DRIVER_VERSION "08 Jan 2007" > -static const char hcd_name[] = "isp116x-hcd"; > - > struct isp116x isp116x_dev; > struct isp116x_platform_data isp116x_board; > static int got_rhsc; /* root hub status change */ > diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c > index e0ca2cb0d4c5..9dbb18343aaa 100644 > --- a/drivers/usb/host/r8a66597-hcd.c > +++ b/drivers/usb/host/r8a66597-hcd.c > @@ -20,7 +20,6 @@ > #define R8A66597_DPRINT(...) > #endif > > -static const char hcd_name[] = "r8a66597_hcd"; > static struct r8a66597 gr8a66597; > > static void get_hub_data(struct usb_device *dev, u16 *hub_devnum, u16 *hubport) >
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 32874d73de84..d1d2d6bd9599 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -92,9 +92,6 @@ #include "isp116x.h" -#define DRIVER_VERSION "08 Jan 2007" -static const char hcd_name[] = "isp116x-hcd"; - struct isp116x isp116x_dev; struct isp116x_platform_data isp116x_board; static int got_rhsc; /* root hub status change */ diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index e0ca2cb0d4c5..9dbb18343aaa 100644 --- a/drivers/usb/host/r8a66597-hcd.c +++ b/drivers/usb/host/r8a66597-hcd.c @@ -20,7 +20,6 @@ #define R8A66597_DPRINT(...) #endif -static const char hcd_name[] = "r8a66597_hcd"; static struct r8a66597 gr8a66597; static void get_hub_data(struct usb_device *dev, u16 *hub_devnum, u16 *hubport)
Both the isp116x-hcd and r8a66597-hcd drivers have an unused hcd_name variable, drop. isp116x-hcd also defines an unused DRIVER_VERSION, so drop that while in here. Cc: Marek Vasut <marex@denx.de> (maintainer:USB) Signed-off-by: Tom Rini <trini@konsulko.com> --- drivers/usb/host/isp116x-hcd.c | 3 --- drivers/usb/host/r8a66597-hcd.c | 1 - 2 files changed, 4 deletions(-)