Patchwork 'Fix' PR48086 by disabling LTO on darwin

login
register
mail settings
Submitter Mike Stump
Date March 14, 2011, 2:53 a.m.
Message ID <AF8EF2DB-5CD9-4074-ABE1-EB3EE0A75136@comcast.net>
Download mbox | patch
Permalink /patch/86656/
State New
Headers show

Comments

Mike Stump - March 14, 2011, 2:53 a.m.
On Mar 13, 2011, at 5:57 PM, Jack Howarth wrote:
> Okay for gcc trunk?

Ok, applied.  I updated the wording of the checkin slightly, hope you don't mind.  Thanks.  Hate to find out late in the game, but, at least we figured it out before release.
2011-03-13  Jack Howarth  <howarth@bromo.med.uc.edu>

	PR lto/48086
	* configure.ac: Disable LTO on darwin due to an assembler change in
	Xcode 3.2.6/4.0 that limits the total number of sections/segments to
	under 256.
	* configure: Regenerate.
Jack Howarth - March 14, 2011, 3:24 a.m.
On Sun, Mar 13, 2011 at 07:53:23PM -0700, Mike Stump wrote:
> On Mar 13, 2011, at 5:57 PM, Jack Howarth wrote:
> > Okay for gcc trunk?
> 
> Ok, applied.  I updated the wording of the checkin slightly, hope you don't mind.  Thanks.  Hate to find out late in the game, but, at least we figured it out before release.
> 

Mike,
   I opened PR48108 for the development of containerized LTO for darwin.
I also asked Chris and Nick to mention to the darwin assembler developer that
some notification via the original radar of his proposed fix might have prevented
this snafu or at least given us several months notice to fix it before the
FSF gcc 4.6.0 release was upon us.
           Jack
ps Life would be so much easier if Apple would stop being so secretive with the
Xcode Previews and provided them to the general ADC accounts like in the old days.

> 2011-03-13  Jack Howarth  <howarth@bromo.med.uc.edu>
> 
> 	PR lto/48086
> 	* configure.ac: Disable LTO on darwin due to an assembler change in
> 	Xcode 3.2.6/4.0 that limits the total number of sections/segments to
> 	under 256.
> 	* configure: Regenerate.
> 
> Index: configure
> ===================================================================
> --- configure	(revision 170745)
> +++ configure	(working copy)
> @@ -6206,7 +6206,7 @@
>  else
>    if test x"$default_enable_lto" = x"yes" ; then
>      case $target in
> -      *-apple-darwin* | *-cygwin* | *-mingw*) ;;
> +      *-cygwin* | *-mingw*) ;;
>        # On other non-ELF platforms, LTO has yet to be validated.
>        *) enable_lto=no ;;
>      esac
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 170745)
> +++ configure.ac	(working copy)
> @@ -1743,7 +1743,7 @@
>    build_lto_plugin=yes
>  ],[if test x"$default_enable_lto" = x"yes" ; then
>      case $target in
> -      *-apple-darwin* | *-cygwin* | *-mingw*) ;;
> +      *-cygwin* | *-mingw*) ;;
>        # On other non-ELF platforms, LTO has yet to be validated.
>        *) enable_lto=no ;;
>      esac

>

Patch

Index: configure
===================================================================
--- configure	(revision 170745)
+++ configure	(working copy)
@@ -6206,7 +6206,7 @@ 
 else
   if test x"$default_enable_lto" = x"yes" ; then
     case $target in
-      *-apple-darwin* | *-cygwin* | *-mingw*) ;;
+      *-cygwin* | *-mingw*) ;;
       # On other non-ELF platforms, LTO has yet to be validated.
       *) enable_lto=no ;;
     esac
Index: configure.ac
===================================================================
--- configure.ac	(revision 170745)
+++ configure.ac	(working copy)
@@ -1743,7 +1743,7 @@ 
   build_lto_plugin=yes
 ],[if test x"$default_enable_lto" = x"yes" ; then
     case $target in
-      *-apple-darwin* | *-cygwin* | *-mingw*) ;;
+      *-cygwin* | *-mingw*) ;;
       # On other non-ELF platforms, LTO has yet to be validated.
       *) enable_lto=no ;;
     esac