Patchwork Added missing sigbus_reraise() to non-Linux platforms

login
register
mail settings
Submitter Palle Lyckegaard
Date March 13, 2011, 8:16 p.m.
Message ID <alpine.NEB.2.00.1103132013560.15407@otaku.freeshell.org>
Download mbox | patch
Permalink /patch/86614/
State New
Headers show

Comments

Palle Lyckegaard - March 13, 2011, 8:16 p.m.
Hi,

File cpus.c seems to be missing sigbus_reraise() on non-Linux platforms. 
The following patch fixes building qemu on Solaris 11 Express (SPARC).

Regards
Palle




Signed-off-by: Palle Lyckegaard <palle@lyckegaard.dk>
---
  cpus.c |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)
Stefan Hajnoczi - March 14, 2011, 10:03 a.m.
On Sun, Mar 13, 2011 at 8:16 PM, Palle Lyckegaard <palle@lyckegaard.dk> wrote:
> Hi,
>
> File cpus.c seems to be missing sigbus_reraise() on non-Linux platforms. The
> following patch fixes building qemu on Solaris 11 Express (SPARC).
>
> Regards
> Palle
>
>
>
>
> Signed-off-by: Palle Lyckegaard <palle@lyckegaard.dk>
> ---
>  cpus.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Great to see your SPARC Solaris 11 buildslave already catching build
breakages.  Thanks for the patch!

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Jan Kiszka - March 14, 2011, 10:44 a.m.
On 2011-03-14 11:03, Stefan Hajnoczi wrote:
> On Sun, Mar 13, 2011 at 8:16 PM, Palle Lyckegaard <palle@lyckegaard.dk> wrote:
>> Hi,
>>
>> File cpus.c seems to be missing sigbus_reraise() on non-Linux platforms. The
>> following patch fixes building qemu on Solaris 11 Express (SPARC).
>>
>> Regards
>> Palle
>>
>>
>>
>>
>> Signed-off-by: Palle Lyckegaard <palle@lyckegaard.dk>
>> ---
>>  cpus.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> Great to see your SPARC Solaris 11 buildslave already catching build
> breakages.  Thanks for the patch!
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

There is already an (implicit) fix [1] on the way. Will come via
uq/master unless someone applies it earlier directly.

Jan

[1] http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/68818

Patch

diff --git a/cpus.c b/cpus.c
index 077729c..02ba1be 100644
--- a/cpus.c
+++ b/cpus.c
@@ -250,6 +250,11 @@  static void qemu_init_sigbus(void)
  static void qemu_init_sigbus(void)
  {
  }
+
+static void sigbus_reraise(void)
+{
+}
+
  #endif /* !CONFIG_LINUX */

  #ifndef _WIN32