| Message ID | 1300035271-8138-1-git-send-email-jslaby@suse.cz |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sunday 13 March 2011 18:54:30 ext Jiri Slaby, you wrote: > Currently there is a warning emitted by the cdc-phonet driver: > WARNING: at include/linux/netdevice.h:1557 usbpn_probe+0x3bb/0x3f0 > [cdc_phonet]() Modules linked in: ... > Pid: 5877, comm: insmod Not tainted 2.6.37.3-16-desktop #1 > Call Trace: > [<ffffffff810059b9>] dump_trace+0x79/0x340 > [<ffffffff81520fdc>] dump_stack+0x69/0x6f > [<ffffffff810580eb>] warn_slowpath_common+0x7b/0xc0 > [<ffffffffa00254fb>] usbpn_probe+0x3bb/0x3f0 [cdc_phonet] > ... > ---[ end trace f5d3e02908603ab4 ]--- > netif_stop_queue() cannot be called before register_netdev() > > So remove netif_stop_queue from the probe funtction to avoid that. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > Cc: David S. Miller <davem@davemloft.net> Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com> Date: Mon, 14 Mar 2011 09:39:56 +0200 > On Sunday 13 March 2011 18:54:30 ext Jiri Slaby, you wrote: >> Currently there is a warning emitted by the cdc-phonet driver: >> WARNING: at include/linux/netdevice.h:1557 usbpn_probe+0x3bb/0x3f0 >> [cdc_phonet]() Modules linked in: ... >> Pid: 5877, comm: insmod Not tainted 2.6.37.3-16-desktop #1 >> Call Trace: >> [<ffffffff810059b9>] dump_trace+0x79/0x340 >> [<ffffffff81520fdc>] dump_stack+0x69/0x6f >> [<ffffffff810580eb>] warn_slowpath_common+0x7b/0xc0 >> [<ffffffffa00254fb>] usbpn_probe+0x3bb/0x3f0 [cdc_phonet] >> ... >> ---[ end trace f5d3e02908603ab4 ]--- >> netif_stop_queue() cannot be called before register_netdev() >> >> So remove netif_stop_queue from the probe funtction to avoid that. >> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >> Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> >> Cc: David S. Miller <davem@davemloft.net> > > Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c index 109751b..4cf4e36 100644 --- a/drivers/net/usb/cdc-phonet.c +++ b/drivers/net/usb/cdc-phonet.c @@ -392,7 +392,6 @@ int usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id) pnd = netdev_priv(dev); SET_NETDEV_DEV(dev, &intf->dev); - netif_stop_queue(dev); pnd->dev = dev; pnd->usb = usb_get_dev(usbdev);
Currently there is a warning emitted by the cdc-phonet driver: WARNING: at include/linux/netdevice.h:1557 usbpn_probe+0x3bb/0x3f0 [cdc_phonet]() Modules linked in: ... Pid: 5877, comm: insmod Not tainted 2.6.37.3-16-desktop #1 Call Trace: [<ffffffff810059b9>] dump_trace+0x79/0x340 [<ffffffff81520fdc>] dump_stack+0x69/0x6f [<ffffffff810580eb>] warn_slowpath_common+0x7b/0xc0 [<ffffffffa00254fb>] usbpn_probe+0x3bb/0x3f0 [cdc_phonet] ... ---[ end trace f5d3e02908603ab4 ]--- netif_stop_queue() cannot be called before register_netdev() So remove netif_stop_queue from the probe funtction to avoid that. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Cc: David S. Miller <davem@davemloft.net> --- drivers/net/usb/cdc-phonet.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)