[1/1] package: Add thunderbolt-tools package

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Add package thunderbolt-tools to handle Thunderbolt devices.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 package/Config.in                              |  1 +
 package/thunderbolt-tools/Config.in            | 11 +++++++++++
 package/thunderbolt-tools/thunderbolt-tools.mk | 14 ++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/thunderbolt-tools/Config.in
 create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk

Hi Andrei,

thank you for your contribution. Some change requests below.

On Thu, Jan 25, 2018 at 2:09 PM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Add package thunderbolt-tools to handle Thunderbolt devices.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  package/Config.in                              |  1 +
>  package/thunderbolt-tools/Config.in            | 11 +++++++++++
>  package/thunderbolt-tools/thunderbolt-tools.mk | 14 ++++++++++++++
>  3 files changed, 26 insertions(+)
>  create mode 100644 package/thunderbolt-tools/Config.in
>  create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk

Please add yourself to the DEVELOPERS file.

package/thunderbolt-tools/thunderbolt-tools.hash is missing.

> diff --git a/package/Config.in b/package/Config.in
> index 00451f526d..d638ac3a72 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -505,6 +505,7 @@ endmenu
>         source "package/sunxi-mali/Config.in"
>         source "package/sysstat/Config.in"
>         source "package/targetcli-fb/Config.in"
> +       source "package/thunderbolt-tools/Config.in"
>         source "package/ti-gfx/Config.in"
>         source "package/ti-sgx-demos/Config.in"
>         source "package/ti-sgx-km/Config.in"
> diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
> new file mode 100644
> index 0000000000..1057300772
> --- /dev/null
> +++ b/package/thunderbolt-tools/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_THUNDERBOLT_TOOLS
> +       bool "thunderbolt-tools"
> +#      select BR2_TOOLCHAIN_BUILDROOT_CXX

you mean "depends on BR2_INSTALL_LIBSTDCPP"

> +       select BR2_PACKAGE_BOOST
> +       select BR2_PACKAGE_BOOST_FILESYSTEM
> +       depends on BR2_PACKAGE_HAS_UDEV
> +       help
> +         Thunderbolt tools for Linux

Project URL is missing

> +
> +comment "thunderbolt-tools package needs udev provided by systemd of eudev, C++"
> +       depends on BR2_PACKAGE_HAS_UDEV
> diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
> new file mode 100644
> index 0000000000..5fd469c4ef
> --- /dev/null
> +++ b/package/thunderbolt-tools/thunderbolt-tools.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# thunderbolt-tools
> +#
> +################################################################################
> +
> +THUNDERBOLT_TOOLS_VERSION = master

use a special commit ID here

> +THUNDERBOLT_TOOLS_SITE = https://github.com/01org/thunderbolt-software-user-space.git
> +#THUNDERBOLT_TOOLS_SITE = $(call github,01org,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))

use githun helper

> +THUNDERBOLT_TOOLS_SITE_METHOD = git

if you are using github helper or git URL you don't need to specify
the site method

> +
> +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev

Add licence info, i.e.
https://github.com/intel/thunderbolt-software-user-space/blob/master/COPYING
and SPDX type of the licence. See the manual.

> +$(eval $(cmake-package))
> --
> 2.14.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Hi Yegor,

Thanks for review,

On Thu, Jan 25, 2018 at 03:19:39PM +0100, Yegor Yefremov wrote:
> > +
> > +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
> 
> Add licence info, i.e.
> https://github.com/intel/thunderbolt-software-user-space/blob/master/COPYING
> and SPDX type of the licence. See the manual.

It is "BSD-style" ;).

If I cannot get SPDX type, can I copy license file to
package directory and specify it like:

THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING


Best regards 
Andrei Emeltchenko

On Thu, Jan 25, 2018 at 5:38 PM, Andrei Emeltchenko
<andrei.emeltchenko.news@gmail.com> wrote:
> Hi Yegor,
>
> Thanks for review,
>
> On Thu, Jan 25, 2018 at 03:19:39PM +0100, Yegor Yefremov wrote:
>> > +
>> > +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
>>
>> Add licence info, i.e.
>> https://github.com/intel/thunderbolt-software-user-space/blob/master/COPYING
>> and SPDX type of the licence. See the manual.
>
> It is "BSD-style" ;).
>
> If I cannot get SPDX type, can I copy license file to
> package directory and specify it like:
>
> THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING

Looks like BSD-3-Clause [1]

By the way the patch title should be:

thunderbolt-tools: new package

[1] https://spdx.org/licenses/BSD-3-Clause.html

Yegor