| Message ID | 20180123203752.15057-1-chrisadr@gentoo.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Scott Wood |
| Headers | show |
| Series | [PATCH-next] powerpc/fsl_pci: Use PTR_ERR_OR_ZERO | expand |
On 01/23/2018 12:37 PM, Christopher Díaz Riveros wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org> > --- Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > arch/powerpc/sysdev/fsl_pci.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c > index cc20d2255d7f..142184635c81 100644 > --- a/arch/powerpc/sysdev/fsl_pci.c > +++ b/arch/powerpc/sysdev/fsl_pci.c > @@ -1304,10 +1304,7 @@ static int add_err_dev(struct platform_device *pdev) > pdev->resource, > pdev->num_resources, > &pd, sizeof(pd)); > - if (IS_ERR(errdev)) > - return PTR_ERR(errdev); > - > - return 0; > + return PTR_ERR_OR_ZERO(errdev); > } > > static int fsl_pci_probe(struct platform_device *pdev) >
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index cc20d2255d7f..142184635c81 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -1304,10 +1304,7 @@ static int add_err_dev(struct platform_device *pdev) pdev->resource, pdev->num_resources, &pd, sizeof(pd)); - if (IS_ERR(errdev)) - return PTR_ERR(errdev); - - return 0; + return PTR_ERR_OR_ZERO(errdev); } static int fsl_pci_probe(struct platform_device *pdev)
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org> --- arch/powerpc/sysdev/fsl_pci.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)