| Message ID | 20180123101727.31028-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: ds1302: remove redundant initializations of pointer bp | expand |
On 23/01/2018 at 10:17:27 +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pointe bp is being initialized and this value is never read, it > is being updated to the same value later just before it is going to > be used. Remove the initialization as it is never read and keep > the setting of bp closer to the use of bp. > > Cleans up clang warnings: > drivers/rtc/rtc-ds1302.c:115:7: warning: Value stored to 'bp' during > its initialization is never read > drivers/rtc/rtc-ds1302.c:46:7: warning: Value stored to 'bp' during > its initialization is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/rtc/rtc-ds1302.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c index 0ec4be62322b..43bcb17c922e 100644 --- a/drivers/rtc/rtc-ds1302.c +++ b/drivers/rtc/rtc-ds1302.c @@ -43,7 +43,7 @@ static int ds1302_rtc_set_time(struct device *dev, struct rtc_time *time) { struct spi_device *spi = dev_get_drvdata(dev); u8 buf[1 + RTC_CLCK_LEN]; - u8 *bp = buf; + u8 *bp; int status; /* Enable writing */ @@ -112,7 +112,7 @@ static int ds1302_probe(struct spi_device *spi) struct rtc_device *rtc; u8 addr; u8 buf[4]; - u8 *bp = buf; + u8 *bp; int status; /* Sanity check board setup data. This may be hooked up