| Message ID | 20180123080840.768-1-jakub.kicinski@netronome.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] i40e: flower: check if TC offload is enabled on a netdev | expand |
Tue, Jan 23, 2018 at 09:08:40AM CET, jakub.kicinski@netronome.com wrote: >Since TC block changes drivers are required to check if >the TC hw offload flag is set on the interface themselves. > >Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") >Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from binding phase to rule insertion phase") >Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> >Reviewed-by: Simon Horman <simon.horman@netronome.com> Acked-by: Jiri Pirko <jiri@mellanox.com>
On 1/23/2018 12:08 AM, Jakub Kicinski wrote: > Since TC block changes drivers are required to check if > the TC hw offload flag is set on the interface themselves. > > Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") > Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from binding phase to rule insertion phase") > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Simon Horman <simon.horman@netronome.com> Acked-by: Amritha Nambiar <amritha.nambiar@intel.com> > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 42dcaefc4c19..af792112a2d3 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -7505,6 +7505,8 @@ static int i40e_setup_tc_cls_flower(struct i40e_netdev_priv *np, > { > struct i40e_vsi *vsi = np->vsi; > > + if (!tc_can_offload(vsi->netdev)) > + return -EOPNOTSUPP; > if (cls_flower->common.chain_index) > return -EOPNOTSUPP; > >
On Tue, 2018-01-23 at 00:08 -0800, Jakub Kicinski wrote: > Since TC block changes drivers are required to check if > the TC hw offload flag is set on the interface themselves. > > Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") > Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from > binding phase to rule insertion phase") > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Simon Horman <simon.horman@netronome.com> > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Dave, feel free to pick this up.
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Date: Tue, 23 Jan 2018 08:47:29 -0800 > On Tue, 2018-01-23 at 00:08 -0800, Jakub Kicinski wrote: >> Since TC block changes drivers are required to check if >> the TC hw offload flag is set on the interface themselves. >> >> Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") >> Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from >> binding phase to rule insertion phase") >> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> >> Reviewed-by: Simon Horman <simon.horman@netronome.com> >> --- >> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > > Dave, feel free to pick this up. Ok, done. Thanks.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 42dcaefc4c19..af792112a2d3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -7505,6 +7505,8 @@ static int i40e_setup_tc_cls_flower(struct i40e_netdev_priv *np, { struct i40e_vsi *vsi = np->vsi; + if (!tc_can_offload(vsi->netdev)) + return -EOPNOTSUPP; if (cls_flower->common.chain_index) return -EOPNOTSUPP;
Since TC block changes drivers are required to check if the TC hw offload flag is set on the interface themselves. Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from binding phase to rule insertion phase") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+)