| Message ID | 20180122061121.9702-1-joseph.kogut@gmail.com |
|---|---|
| State | Accepted |
| Commit | 032e229e4425ff7bc1c128be5ebc467e9d6c4203 |
| Headers | show |
| Series | [1/1] gconf: add dependency on toolchain w/ dynamic lib | expand |
>>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes: > GConf fails to build when BR2_STATIC_LIBS=y. > Fixes: > http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/ > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> > --- > Thanks for the feedback, Baruch. I've updated the commit message. Committed, thanks.
Hi Peter, On Sat, Feb 03, 2018 at 11:28:10PM +0100, Peter Korsgaard wrote: > >>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes: > > > GConf fails to build when BR2_STATIC_LIBS=y. > > Fixes: > > http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/ > > > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> > > --- > > > Thanks for the feedback, Baruch. I've updated the commit message. > > Committed, thanks. Not in master as of 5f3246a1d69 (gdk-pixbuf: unbreak gdk-pixbuf loaders.cache). baruch
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes: > Hi Peter, > On Sat, Feb 03, 2018 at 11:28:10PM +0100, Peter Korsgaard wrote: >> >>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes: >> >> > GConf fails to build when BR2_STATIC_LIBS=y. >> > Fixes: >> > http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/ >> >> > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> >> > --- >> >> > Thanks for the feedback, Baruch. I've updated the commit message. >> >> Committed, thanks. > Not in master as of 5f3246a1d69 (gdk-pixbuf: unbreak gdk-pixbuf > loaders.cache). Sorry, fixed now.
diff --git a/package/gconf/Config.in b/package/gconf/Config.in index a68287525b..a967d61644 100644 --- a/package/gconf/Config.in +++ b/package/gconf/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_GCONF depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2 depends on BR2_USE_MMU # dbus, libglib2 depends on BR2_USE_WCHAR # libglib2 + depends on !BR2_STATIC_LIBS select BR2_PACKAGE_DBUS select BR2_PACKAGE_DBUS_GLIB select BR2_PACKAGE_LIBGLIB2 @@ -14,6 +15,7 @@ config BR2_PACKAGE_GCONF https://projects.gnome.org/gconf/ -comment "gconf needs a toolchain w/ threads, wchar" +comment "gconf needs a toolchain w/ threads, wchar, dynamic library" depends on BR2_USE_MMU - depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR \ + || BR2_STATIC_LIBS
GConf fails to build when BR2_STATIC_LIBS=y. Fixes: http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/ Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> --- Thanks for the feedback, Baruch. I've updated the commit message. package/gconf/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)