| Message ID | 20180119192350.15767-1-cera@cera.cz |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] be2net: restore properly promisc mode after queues reconfiguration | expand |
From: Ivan Vecera <cera@cera.cz> Date: Fri, 19 Jan 2018 20:23:50 +0100 > The commit 622190669403 ("be2net: Request RSS capability of Rx interface > depending on number of Rx rings") modified be_update_queues() so the > IFACE (HW representation of the netdevice) is destroyed and then > re-created. This causes a regression because potential promiscuous mode > is not restored properly during be_open() because the driver thinks > that the HW has promiscuous mode already enabled. > > Note that Lancer is not affected by this bug because RX-filter flags are > disabled during be_close() for this chipset. > > Cc: Sathya Perla <sathya.perla@broadcom.com> > Cc: Ajit Khaparde <ajit.khaparde@broadcom.com> > Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > Cc: Somnath Kotur <somnath.kotur@broadcom.com> > > Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Applied and queued up for -stable, thank you.
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index c6e859a27ee6..e180657a02ef 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -4634,6 +4634,15 @@ int be_update_queues(struct be_adapter *adapter) be_schedule_worker(adapter); + /* + * The IF was destroyed and re-created. We need to clear + * all promiscuous flags valid for the destroyed IF. + * Without this promisc mode is not restored during + * be_open() because the driver thinks that it is + * already enabled in HW. + */ + adapter->if_flags &= ~BE_IF_FLAGS_ALL_PROMISCUOUS; + if (netif_running(netdev)) status = be_open(netdev);
The commit 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") modified be_update_queues() so the IFACE (HW representation of the netdevice) is destroyed and then re-created. This causes a regression because potential promiscuous mode is not restored properly during be_open() because the driver thinks that the HW has promiscuous mode already enabled. Note that Lancer is not affected by this bug because RX-filter flags are disabled during be_close() for this chipset. Cc: Sathya Perla <sathya.perla@broadcom.com> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Cc: Somnath Kotur <somnath.kotur@broadcom.com> Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") Signed-off-by: Ivan Vecera <ivecera@redhat.com> --- drivers/net/ethernet/emulex/benet/be_main.c | 9 +++++++++ 1 file changed, 9 insertions(+)