| Message ID | 20110310223636.GA11399@asset.uwaterloo.ca |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: j223yang@asset.uwaterloo.ca Date: Thu, 10 Mar 2011 17:36:37 -0500 > Simply remove redundant 'dev' NULL check. > Source code uses spaces instead of TAB, except 'printk' and 'return' lines. > > > Signed-off-by: Jinqiu Yang <crindy646@gmail.com> Patch is still corrupted by your email client, the same way as before. And when you fix it, you don't need to mention this in the commit message. Please, take the time to do some testing by sending the patch to yourself, and then try to apply the patch in the email you receive. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Thu, 10 Mar 2011 14:39:42 -0800 (PST) > From: j223yang@asset.uwaterloo.ca > Date: Thu, 10 Mar 2011 17:36:37 -0500 > >> Simply remove redundant 'dev' NULL check. >> Source code uses spaces instead of TAB, except 'printk' and 'return' lines. >> >> >> Signed-off-by: Jinqiu Yang <crindy646@gmail.com> > > Patch is still corrupted by your email client, the same way as before. Sorry, I apologize, this is not your fault. This is one of those terrible old drivers that have bad coding style. I'll apply this patch, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* David Miller <davem@davemloft.net>: > This is one of those terrible old drivers that have bad coding > style. Would you like a cleanup patch for this driver? Best regards, Nicolas Kaiser -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/net/ariadne.c 2011-03-10 11:20:14.076039323 -0500 +++ b/drivers/net/ariadne.c 2011-03-10 11:21:59.111164537 -0500 @@ -425,11 +425,6 @@ static irqreturn_t ariadne_interrupt(int int csr0, boguscnt; int handled = 0; - if (dev == NULL) { - printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n"); - return IRQ_NONE; - } - lance->RAP = CSR0; /* PCnet-ISA Controller Status */ if (!(lance->RDP & INTR)) /* Check if any interrupt has been */
Simply remove redundant 'dev' NULL check. Source code uses spaces instead of TAB, except 'printk' and 'return' lines. Signed-off-by: Jinqiu Yang <crindy646@gmail.com> --- ariadne.c | 5 ----- 1 file changed, 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html