diff mbox series

sm501: Add missing break to case

Message ID 20180119014313.445517456CD@zero.eik.bme.hu
State New
Headers show
Series sm501: Add missing break to case | expand

Commit Message

BALATON Zoltan Jan. 18, 2018, 6:01 p.m. UTC
Noticed by Coverity, forgotten in 5690d9ece

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/display/sm501.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Gibson Jan. 19, 2018, 4:16 a.m. UTC | #1
On Thu, Jan 18, 2018 at 07:01:19PM +0100, BALATON Zoltan wrote:
> Noticed by Coverity, forgotten in 5690d9ece
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Applied to ppc-for-2.12, thanks.

> ---
>  hw/display/sm501.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 4f7dc59b2..134cbed 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
>          break;
>      case SM501_COMMAND_LIST_STATUS:
>          ret = 0x00180002; /* FIFOs are empty, everything idle */
> +        break;
>      case SM501_IRQ_MASK:
>          ret = s->irq_mask;
>          break;
diff mbox series

Patch

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 4f7dc59b2..134cbed 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -797,6 +797,7 @@  static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
         break;
     case SM501_COMMAND_LIST_STATUS:
         ret = 0x00180002; /* FIFOs are empty, everything idle */
+        break;
     case SM501_IRQ_MASK:
         ret = s->irq_mask;
         break;