[lucid,maverick] SRU: visible screen corruption on Casper

Submitted by Paolo Pisati on March 10, 2011, 4:39 p.m.

Details

Message ID 4D78FEC7.7080100@canonical.com
State New
Headers show

Commit Message

Paolo Pisati March 10, 2011, 4:39 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

SRU Justification:

    Impact: severe graphics corruption on Casper.
    Fix: see attached patch.
    Testcase: boot the board and watch the screen.

Buglink:
https://bugs.launchpad.net/ubuntu/+source/linux-mvl-dove/+bug/732721

This affects lucid/mvl-dove and maverick/mvl-dove.

This fix a regression in the lucid/mvl-dove and maverick/mvl-dove
- -proposed kernel.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNeP7HAAoJEMupOQaAohtUDQYH/3XUS4ZRMmC9lSZCecv9Zjrb
0vDb8/IKxgcZh4ui/4VgIyqerLLHImjyDh/NjxM8dzfeRad31nUyUlGj9fPQrNwz
ZoUdzq1ypaa2c6AA9lnV0pHQMMF22n/bDdY2P8tUQ3tIgGj0v+jtG62e+OH+cgsB
xwCPhJ2LoAtgkJSmGviPZoTPoDL1ZFF9eHvIWFBfh0Qnj2kCC8YXHrpkneoQP1fh
44TuJfZpSFfUm3Le1tkOrYT2OryUW3SlgJbKcsrP8apw/fbu5LQGGzZsglQ4APlr
1bWtteL6rAxT3rXrUxRphZJ8W1WuKS43RBAVH4crsER7l4OdjXN4xfXVoJ6yPWo=
=o6bQ
-----END PGP SIGNATURE-----

Comments

Eric Miao March 11, 2011, 1:23 a.m.
Hi Paolo,

Great you identify the guilty patch. It would be even better
if you could add some comments why this commit is causing
corruption?

On Friday, March 11, 2011, Paolo Pisati <paolo.pisati@canonical.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> SRU Justification:
>
>     Impact: severe graphics corruption on Casper.
>     Fix: see attached patch.
>     Testcase: boot the board and watch the screen.
>
> Buglink:
> https://bugs.launchpad.net/ubuntu/+source/linux-mvl-dove/+bug/732721
>
> This affects lucid/mvl-dove and maverick/mvl-dove.
>
> This fix a regression in the lucid/mvl-dove and maverick/mvl-dove
> - -proposed kernel.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJNeP7HAAoJEMupOQaAohtUDQYH/3XUS4ZRMmC9lSZCecv9Zjrb
> 0vDb8/IKxgcZh4ui/4VgIyqerLLHImjyDh/NjxM8dzfeRad31nUyUlGj9fPQrNwz
> ZoUdzq1ypaa2c6AA9lnV0pHQMMF22n/bDdY2P8tUQ3tIgGj0v+jtG62e+OH+cgsB
> xwCPhJ2LoAtgkJSmGviPZoTPoDL1ZFF9eHvIWFBfh0Qnj2kCC8YXHrpkneoQP1fh
> 44TuJfZpSFfUm3Le1tkOrYT2OryUW3SlgJbKcsrP8apw/fbu5LQGGzZsglQ4APlr
> 1bWtteL6rAxT3rXrUxRphZJ8W1WuKS43RBAVH4crsER7l4OdjXN4xfXVoJ6yPWo=
> =o6bQ
> -----END PGP SIGNATURE-----
>
Paolo Pisati March 11, 2011, 7:54 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/11/2011 02:23 AM, Eric Miao wrote:
> Hi Paolo,
> 
> Great you identify the guilty patch. It would be even better
> if you could add some comments why this commit is causing
> corruption?

Hi Eric,

unfortunately i can't comments so much on it since it came with the
Marvell 5.3.6 BSP update and i just did a mere bisect to find it: i
think we could be better served asking to our Marvell contact.


bye,
p.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNedUaAAoJEMupOQaAohtU3y0IAMJ9CdELDwtDgMhtYktlkNs6
yburUqjPP9nhy89OfQPWnQto8lVgIbn3iYurlkzftBowrSc38uvyAHR0tZMaSkCy
NfGyLW4BHYaC9VbohoS/cM8t1xgtHNvkgO9eqlAX5mUDIhlglS+AIm9uHiY9LEu8
iT0pIYJL45Mqh/REkZ/0xvhhAaaIcIR3V/jdIFB+cNHpXBC8BoYsJxA1qlG1Jdjt
BPMdR+lBe4mvZ/d2ZR8GoQiY2nS6eNofZ+AxrlT/pCfjbNL9TENK0g3ovv1BCD4m
yCeAZ2Fw6U0OjuUzgXVTUGJljR3Sx89z/1YR4CEE/s76O2WdrizSQr4S7e0SgW0=
=CY2i
-----END PGP SIGNATURE-----
Stefan Bader March 11, 2011, 8:08 a.m.
On 03/10/2011 05:39 PM, Paolo Pisati wrote:
> SRU Justification:
> 
>     Impact: severe graphics corruption on Casper.
>     Fix: see attached patch.
>     Testcase: boot the board and watch the screen.
> 
> Buglink:
> https://bugs.launchpad.net/ubuntu/+source/linux-mvl-dove/+bug/732721
> 
> This affects lucid/mvl-dove and maverick/mvl-dove.
> 
> This fix a regression in the lucid/mvl-dove and maverick/mvl-dove
> -proposed kernel.

Looks good to me. Repeating my comments from the other SRU, I would suggest to
use [lucid-mvl-dove, maverick-mvl-dove] or maybe [(lucid, maverick)-mvl-dove] in
the subject. That way it would be clear (at least to me looking at it quickly)
that this only needs to go to the topic branches.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Eric Miao March 11, 2011, 9:59 a.m.
On Fri, Mar 11, 2011 at 3:54 PM, Paolo Pisati
<paolo.pisati@canonical.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 03/11/2011 02:23 AM, Eric Miao wrote:
>> Hi Paolo,
>>
>> Great you identify the guilty patch. It would be even better
>> if you could add some comments why this commit is causing
>> corruption?
>
> Hi Eric,
>
> unfortunately i can't comments so much on it since it came with the
> Marvell 5.3.6 BSP update and i just did a mere bisect to find it: i
> think we could be better served asking to our Marvell contact.

No problem. Patch looks fine, just wondering the exact cause of
this. Cc'ed Saeed to let Marvell know this.

>
>
> bye,
> p.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJNedUaAAoJEMupOQaAohtU3y0IAMJ9CdELDwtDgMhtYktlkNs6
> yburUqjPP9nhy89OfQPWnQto8lVgIbn3iYurlkzftBowrSc38uvyAHR0tZMaSkCy
> NfGyLW4BHYaC9VbohoS/cM8t1xgtHNvkgO9eqlAX5mUDIhlglS+AIm9uHiY9LEu8
> iT0pIYJL45Mqh/REkZ/0xvhhAaaIcIR3V/jdIFB+cNHpXBC8BoYsJxA1qlG1Jdjt
> BPMdR+lBe4mvZ/d2ZR8GoQiY2nS6eNofZ+AxrlT/pCfjbNL9TENK0g3ovv1BCD4m
> yCeAZ2Fw6U0OjuUzgXVTUGJljR3Sx89z/1YR4CEE/s76O2WdrizSQr4S7e0SgW0=
> =CY2i
> -----END PGP SIGNATURE-----
>
Tim Gardner March 11, 2011, 12:11 p.m.
On 03/10/2011 04:39 PM, Paolo Pisati wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> SRU Justification:
>
>      Impact: severe graphics corruption on Casper.
>      Fix: see attached patch.
>      Testcase: boot the board and watch the screen.
>
> Buglink:
> https://bugs.launchpad.net/ubuntu/+source/linux-mvl-dove/+bug/732721
>
> This affects lucid/mvl-dove and maverick/mvl-dove.
>
> This fix a regression in the lucid/mvl-dove and maverick/mvl-dove
> - -proposed kernel.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJNeP7HAAoJEMupOQaAohtUDQYH/3XUS4ZRMmC9lSZCecv9Zjrb
> 0vDb8/IKxgcZh4ui/4VgIyqerLLHImjyDh/NjxM8dzfeRad31nUyUlGj9fPQrNwz
> ZoUdzq1ypaa2c6AA9lnV0pHQMMF22n/bDdY2P8tUQ3tIgGj0v+jtG62e+OH+cgsB
> xwCPhJ2LoAtgkJSmGviPZoTPoDL1ZFF9eHvIWFBfh0Qnj2kCC8YXHrpkneoQP1fh
> 44TuJfZpSFfUm3Le1tkOrYT2OryUW3SlgJbKcsrP8apw/fbu5LQGGzZsglQ4APlr
> 1bWtteL6rAxT3rXrUxRphZJ8W1WuKS43RBAVH4crsER7l4OdjXN4xfXVoJ6yPWo=
> =o6bQ
> -----END PGP SIGNATURE-----
>

applied to Lucid. Maverick will pickup the change when it gets rebased.
Stefan Bader March 11, 2011, 12:41 p.m.
On 03/11/2011 01:11 PM, Tim Gardner wrote:
> On 03/10/2011 04:39 PM, Paolo Pisati wrote:
> SRU Justification:
> 
>      Impact: severe graphics corruption on Casper.
>      Fix: see attached patch.
>      Testcase: boot the board and watch the screen.
> 
> Buglink:
> https://bugs.launchpad.net/ubuntu/+source/linux-mvl-dove/+bug/732721
> 
> This affects lucid/mvl-dove and maverick/mvl-dove.
> 
> This fix a regression in the lucid/mvl-dove and maverick/mvl-dove
> -proposed kernel.
>>

> applied to Lucid. Maverick will pickup the change when it gets rebased.

master? Cause this change looked like it should only get into the topic branch...

Patch hide | download patch | download mbox

From 687ce2d81ce72d943f230145de4c8b219561bbba Mon Sep 17 00:00:00 2001
From: Paolo Pisati <paolo.pisati@canonical.com>
Date: Thu, 10 Mar 2011 17:13:41 +0100
Subject: [PATCH] Revert "dove: enable lcd0 by default"

This reverts commit 2731149dba658f1ade48d2c030ab2afb88460bf7.

Without reverting this, Casper screen output shows severe graphics corruption.

BugLink: http://bugs.launchpad.net/bugs/732721

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 arch/arm/mach-dove/clcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-dove/clcd.c b/arch/arm/mach-dove/clcd.c
index 59c0edf..20631bd 100755
--- a/arch/arm/mach-dove/clcd.c
+++ b/arch/arm/mach-dove/clcd.c
@@ -37,7 +37,7 @@ 
 #include <ctrlEnv/mvCtrlEnvRegs.h>
 #include "common.h"
 
-unsigned int lcd0_enable = 1;
+unsigned int lcd0_enable;
 module_param(lcd0_enable, uint, 0);
 MODULE_PARM_DESC(lcd0_enable, "set to 1 to enable LCD0 output.");
 unsigned int lcd1_enable = 1;
-- 
1.7.1