diff mbox series

[net-next] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter

Message ID 20180118080555.1627-1-jiri@resnulli.us
State Superseded, archived
Delegated to: David Miller
Headers show
Series [net-next] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter | expand

Commit Message

Jiri Pirko Jan. 18, 2018, 8:05 a.m. UTC 
From: Jiri Pirko <jiri@mellanox.com>

When tcm->tcm_ifindex == TCM_IFINDEX_MAGIC_BLOCK, parent is still passed
down but the value is never used. Compiler does not recognize it and
issues a warning. Silence it down initializing parent to 0.

Reported-by: David Miller <davem@davemloft.net>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 net/sched/cls_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index e500d11da9cd..9683f8550f6f 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -1303,7 +1303,7 @@  static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb)
 	struct tcmsg *tcm = nlmsg_data(cb->nlh);
 	long index_start;
 	long index;
-	u32 parent;
+	u32 parent = 0;
 	int err;
 
 	if (nlmsg_len(cb->nlh) < sizeof(*tcm))