diff mbox series

[OpenWrt-Devel,2/5] firmware: add microcode package for AMD64

Message ID 1516218066-1622-3-git-send-email-wigyori@uid0.hu
State Superseded, archived
Headers show
Series x86: add support for microcode update | expand

Commit Message

Zoltan HERPAI Jan. 17, 2018, 7:41 p.m. UTC
Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu>
---
 package/firmware/linux-firmware/x86.mk | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 package/firmware/linux-firmware/x86.mk

Comments

Hauke Mehrtens Jan. 18, 2018, 9:11 p.m. UTC | #1
On 01/17/2018 08:41 PM, Zoltan HERPAI wrote:
> Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu>
> ---
>  package/firmware/linux-firmware/x86.mk | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 package/firmware/linux-firmware/x86.mk
> 
> diff --git a/package/firmware/linux-firmware/x86.mk b/package/firmware/linux-firmware/x86.mk
> new file mode 100644
> index 0000000..2dfe7b0
> --- /dev/null
> +++ b/package/firmware/linux-firmware/x86.mk
> @@ -0,0 +1,9 @@
> +Package/amd64-microcode = $(call Package/firmware-default,AMD64 CPU microcode)
> +define Package/amd64-microcode/install
> +	$(INSTALL_DIR) $(1)/lib/firmware/amd-ucode
> +	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd.bin $(1)/lib/firmware/amd-ucode
> +	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd_fam15h.bin $(1)/lib/firmware/amd-ucode
> +	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd_fam16h.bin $(1)/lib/firmware/amd-ucode
> +endef
> +$(eval $(call BuildPackage,amd64-microcode))
> +

These microcodes are still from 2016_03_16, Debian already ships some
more recent versions which they got from Suse.

Should we upgrade the linux-firmware package to the most recent version
after these new microcodes are added and do the same for 17.01 and 15.05?

See here for the Debain changelog:
http://metadata.ftp-master.debian.org/changelogs/non-free/a/amd64-microcode/amd64-microcode_3.20171205.1_changelog

Hauke
Zoltan HERPAI Jan. 18, 2018, 10:28 p.m. UTC | #2
On Thu, 18 Jan 2018, Hauke Mehrtens wrote:

> On 01/17/2018 08:41 PM, Zoltan HERPAI wrote:
>> Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu>
>> ---
>>  package/firmware/linux-firmware/x86.mk | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>  create mode 100644 package/firmware/linux-firmware/x86.mk
>>
>> diff --git a/package/firmware/linux-firmware/x86.mk b/package/firmware/linux-firmware/x86.mk
>> new file mode 100644
>> index 0000000..2dfe7b0
>> --- /dev/null
>> +++ b/package/firmware/linux-firmware/x86.mk
>> @@ -0,0 +1,9 @@
>> +Package/amd64-microcode = $(call Package/firmware-default,AMD64 CPU microcode)
>> +define Package/amd64-microcode/install
>> +	$(INSTALL_DIR) $(1)/lib/firmware/amd-ucode
>> +	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd.bin $(1)/lib/firmware/amd-ucode
>> +	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd_fam15h.bin $(1)/lib/firmware/amd-ucode
>> +	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd_fam16h.bin $(1)/lib/firmware/amd-ucode
>> +endef
>> +$(eval $(call BuildPackage,amd64-microcode))
>> +
>
> These microcodes are still from 2016_03_16, Debian already ships some
> more recent versions which they got from Suse.
>
> Should we upgrade the linux-firmware package to the most recent version
> after these new microcodes are added and do the same for 17.01 and 15.05?
>
> See here for the Debain changelog:
> http://metadata.ftp-master.debian.org/changelogs/non-free/a/amd64-microcode/amd64-microcode_3.20171205.1_changelog

Yes, this was discussed on IRC. My impression was that the linux-firmware 
git repo should be doing better than the distros in the first place, but 
looks like that's not the case, so I'll move to use the amd64-microcode 
from Debian.

Regards,
-w-
diff mbox series

Patch

diff --git a/package/firmware/linux-firmware/x86.mk b/package/firmware/linux-firmware/x86.mk
new file mode 100644
index 0000000..2dfe7b0
--- /dev/null
+++ b/package/firmware/linux-firmware/x86.mk
@@ -0,0 +1,9 @@ 
+Package/amd64-microcode = $(call Package/firmware-default,AMD64 CPU microcode)
+define Package/amd64-microcode/install
+	$(INSTALL_DIR) $(1)/lib/firmware/amd-ucode
+	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd.bin $(1)/lib/firmware/amd-ucode
+	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd_fam15h.bin $(1)/lib/firmware/amd-ucode
+	$(INSTALL_DATA) $(PKG_BUILD_DIR)/amd-ucode/microcode_amd_fam16h.bin $(1)/lib/firmware/amd-ucode
+endef
+$(eval $(call BuildPackage,amd64-microcode))
+