From patchwork Thu Mar 10 06:09:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 86194 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 43DA51007D1 for ; Thu, 10 Mar 2011 17:24:28 +1100 (EST) Received: from localhost ([127.0.0.1]:35702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxZIP-00005q-4F for incoming@patchwork.ozlabs.org; Thu, 10 Mar 2011 01:24:25 -0500 Received: from [140.186.70.92] (port=36192 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxZ48-0003e6-Hb for qemu-devel@nongnu.org; Thu, 10 Mar 2011 01:09:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxZ47-0007eG-CE for qemu-devel@nongnu.org; Thu, 10 Mar 2011 01:09:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxZ47-0007dx-1i for qemu-devel@nongnu.org; Thu, 10 Mar 2011 01:09:39 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2A69bgm030195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Mar 2011 01:09:37 -0500 Received: from localhost (dhcp193-58.pnq.redhat.com [10.65.193.58]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2A69aff027241; Thu, 10 Mar 2011 01:09:36 -0500 From: Amit Shah To: Anthony Liguori Date: Thu, 10 Mar 2011 11:39:19 +0530 Message-Id: <0f35b89ae35e35afa8499f8016900ace82bc86a5.1299737220.git.amit.shah@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Amit Shah , qemu list Subject: [Qemu-devel] [PULL (resend, rebase) 5/5] virtio-serial: Don't clear ->have_data() pointer after unplug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org After a port unplug operation, the port->info->have_data() pointer was set to NULL. The problem is, the ->info struct is shared by all ports, effectively disabling writes to other ports. Reported-by: juzhang Signed-off-by: Amit Shah --- hw/virtio-console.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 699f190..0bf35ef 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -82,7 +82,6 @@ static int virtconsole_exitfn(VirtIOSerialPort *port) VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); if (vcon->chr) { - port->info->have_data = NULL; qemu_chr_close(vcon->chr); }