Patchwork [PULL,(resend,rebase),5/5] virtio-serial: Don't clear ->have_data() pointer after unplug

login
register
mail settings
Submitter Amit Shah
Date March 10, 2011, 6:09 a.m.
Message ID <0f35b89ae35e35afa8499f8016900ace82bc86a5.1299737220.git.amit.shah@redhat.com>
Download mbox | patch
Permalink /patch/86194/
State New
Headers show

Comments

Amit Shah - March 10, 2011, 6:09 a.m.
After a port unplug operation, the port->info->have_data() pointer was
set to NULL.  The problem is, the ->info struct is shared by all ports,
effectively disabling writes to other ports.

Reported-by: juzhang <juzhang@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 hw/virtio-console.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 699f190..0bf35ef 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -82,7 +82,6 @@  static int virtconsole_exitfn(VirtIOSerialPort *port)
     VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
 
     if (vcon->chr) {
-        port->info->have_data = NULL;
         qemu_chr_close(vcon->chr);
     }