From patchwork Wed Mar 9 21:55:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 86159 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9D90DB6F88 for ; Thu, 10 Mar 2011 08:56:00 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753194Ab1CIVze (ORCPT ); Wed, 9 Mar 2011 16:55:34 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:22432 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694Ab1CIVzd (ORCPT ); Wed, 9 Mar 2011 16:55:33 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 774279403D; Wed, 9 Mar 2011 22:55:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 704049403B; Wed, 9 Mar 2011 22:55:05 +0100 (CET) Date: Wed, 9 Mar 2011 22:55:05 +0100 (CET) From: Jesper Juhl To: linux-kernel@vger.kernel.org cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netdev@vger.kernel.org, Wensong Zhang , trivial@kernel.org Subject: [PATCH] Fix variable assignment in ip_vs_notrack Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There's no sense to 'ct = ct = ' in ip_vs_notrack(). Just assign nf_ct_get()'s return value directly to the pointer variable 'ct' once. Signed-off-by: Jesper Juhl --- ip_vs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index b7bbd6c..269d1ef 100644 --- a/include/net/ip_vs.h +++ b/include/net/ip_vs.h @@ -1031,7 +1031,7 @@ static inline void ip_vs_notrack(struct sk_buff *skb) { #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) enum ip_conntrack_info ctinfo; - struct nf_conn *ct = ct = nf_ct_get(skb, &ctinfo); + struct nf_conn *ct = nf_ct_get(skb, &ctinfo); if (!ct || !nf_ct_is_untracked(ct)) { nf_reset(skb);