[net-next] bnxt_en: uninitialized variable in bnxt_rx_pkt()
diff mbox series

Message ID 20180116103859.GA3374@mwanda
State Not Applicable, archived
Delegated to: David Miller
Headers show
  • [net-next] bnxt_en: uninitialized variable in bnxt_rx_pkt()
Related show

Commit Message

Dan Carpenter Jan. 16, 2018, 10:38 a.m. UTC
There are a couple failure paths where "len" is used uninitialized.  It
means we record the number of rx_packets incorrectly.

Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>


Dan Carpenter Jan. 16, 2018, 12:05 p.m. UTC | #1
Never mind.  Colin already sent this one.

dan carpenter

diff mbox series

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index cf6ebf1e324b..5b5c4f266f1b 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -1482,7 +1482,7 @@  static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_napi *bnapi, u32 *raw_cons,
 	u32 tmp_raw_cons = *raw_cons;
 	u16 cfa_code, cons, prod, cp_cons = RING_CMP(tmp_raw_cons);
 	struct bnxt_sw_rx_bd *rx_buf;
-	unsigned int len;
+	unsigned int len = 0;
 	u8 *data_ptr, agg_bufs, cmp_type;
 	dma_addr_t dma_addr;
 	struct sk_buff *skb;