diff mbox series

[next] mtd: nand: fix spelling mistake: "suceed"-> "succeed"

Message ID 20180116102808.23232-1-colin.king@canonical.com
State Superseded
Headers show
Series [next] mtd: nand: fix spelling mistake: "suceed"-> "succeed" | expand

Commit Message

Colin Ian King Jan. 16, 2018, 10:28 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Trivial fix to spelling mistakes in dev_err error message text.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/mtd/nand/marvell_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Walter Harms Jan. 16, 2018, 11:06 a.m. UTC | #1 
Am 16.01.2018 11:28, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistakes in dev_err error message text.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/mtd/nand/marvell_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/marvell_nand.c b/drivers/mtd/nand/marvell_nand.c
> index b8fec6093b75..4bd53b360277 100644
> --- a/drivers/mtd/nand/marvell_nand.c
> +++ b/drivers/mtd/nand/marvell_nand.c
> @@ -517,7 +517,7 @@ static int marvell_nfc_prepare_cmd(struct nand_chip *chip)
>  	/* Poll ND_RUN and clear NDSR before issuing any command */
>  	ret = marvell_nfc_wait_ndrun(chip);
>  	if (ret) {
> -		dev_err(nfc->dev, "Last operation did not suceed\n");
> +		dev_err(nfc->dev, "Last operation did not succeed\n");
>  		return ret;
>  	}
>  

not succeed == Failed ??
someone who is debugging may also interessted to know what operation failed.

just my 2 cents,
 wh
Miquel Raynal Jan. 19, 2018, 7:39 a.m. UTC | #2 
Hello,

Can you please change the prefix, it should be:

mtd: nand: marvell:

On Tue, 16 Jan
2018 12:06:08 +0100 walter harms <wharms@bfs.de> wrote:

> Am 16.01.2018 11:28, schrieb Colin King:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Trivial fix to spelling mistakes in dev_err error message text.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/mtd/nand/marvell_nand.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/nand/marvell_nand.c
> > b/drivers/mtd/nand/marvell_nand.c index b8fec6093b75..4bd53b360277
> > 100644 --- a/drivers/mtd/nand/marvell_nand.c
> > +++ b/drivers/mtd/nand/marvell_nand.c
> > @@ -517,7 +517,7 @@ static int marvell_nfc_prepare_cmd(struct
> > nand_chip *chip) /* Poll ND_RUN and clear NDSR before issuing any
> > command */ ret = marvell_nfc_wait_ndrun(chip);
> >  	if (ret) {
> > -		dev_err(nfc->dev, "Last operation did not
> > suceed\n");
> > +		dev_err(nfc->dev, "Last operation did not
> > succeed\n"); return ret;
> >  	}
> >    
> 
> not succeed == Failed ??

I personally do not have a preference, as long as there is a clear
error message in this case.

> someone who is debugging may also interessted to know what operation
> failed.

It is not as easy to do, but starting from enabling dynamic debug in
both the driver and the NAND core should give you enough traces to
locate the issue.

Thanks,
Miquèl
diff mbox series

Patch

diff --git a/drivers/mtd/nand/marvell_nand.c b/drivers/mtd/nand/marvell_nand.c
index b8fec6093b75..4bd53b360277 100644
--- a/drivers/mtd/nand/marvell_nand.c
+++ b/drivers/mtd/nand/marvell_nand.c
@@ -517,7 +517,7 @@  static int marvell_nfc_prepare_cmd(struct nand_chip *chip)
 	/* Poll ND_RUN and clear NDSR before issuing any command */
 	ret = marvell_nfc_wait_ndrun(chip);
 	if (ret) {
-		dev_err(nfc->dev, "Last operation did not suceed\n");
+		dev_err(nfc->dev, "Last operation did not succeed\n");
 		return ret;
 	}