osmo-bsc_nat dropped in unrelated patch

Message ID 20180115202340.GB14510@my.box
State New
Headers show
Series
  • osmo-bsc_nat dropped in unrelated patch
Related show

Commit Message

Neels Hofmeyr Jan. 15, 2018, 8:23 p.m.
Hi dexter,

reading a commit of yours apparently merged to osmo-bsc in November, I notice
that you "secretly sneaked in" this:




in a patch that was supposed to "mgcp: use osmo-mgw to switch RTP streams".
http://git.osmocom.org/osmo-bsc/commit/?id=39c609b7c924524172ad311bdf89f92b7ccf175a

So since we merged that patch, osmo-bsc_nat is no longer part of the osmo-bsc
build. That's certainly not intended, is it?

Confirm and please fix that. thx!

~N

Comments

Harald Welte Jan. 16, 2018, 7:19 a.m. | #1
Hi Neels,

On Mon, Jan 15, 2018 at 09:23:40PM +0100, Neels Hofmeyr wrote:
> So since we merged that patch, osmo-bsc_nat is no longer part of the osmo-bsc
> build. That's certainly not intended, is it?

It is intended, or at least expected.  osmo-bsc_nat is heavily tied to SCCPlite.

We have freed osmo-bsc from those ties and it implements "generic SCCP" on top of
the SCCP User SAP of libosmosigtran.

Until somebody will do the same amount of porting in osmo-bsc_nat, I think it is best
that the two programs dealing natively with SCCPlite are in openbsc.git.

> Confirm and please fix that. thx!

If there's an easy fix, it might be worth looking into it.  However, I think with
all the rework on the SCCP and MGCP side, it makes sense to leave it disabled
until we have a clear plan how a new AoIP-enabled osmo-bsc_nat might look like.

Regards,
	Harald

Patch

diff --git a/src/Makefile.am b/src/Makefile.am
index d04f025..dd1ad3d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -33,5 +33,4 @@  SUBDIRS += \
 	utils \
 	ipaccess \
 	osmo-bsc \
-	osmo-bsc_nat \
 	$(NULL)