| Message ID | 20180115154812.10013-1-ezequiel@vanguardiasur.com.ar |
|---|---|
| State | Accepted |
| Commit | d55c8159bddd133610e18174b4c4d02a3484a173 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [U-Boot] nand: arasan: Select CONFIG_SYS_NAND_SELF_INIT | expand |
On 15.1.2018 16:48, Ezequiel Garcia wrote: > The Arasan NFC driver requires the self-init mode, > so it should select it. > > Instead of having the config header define the macro, > it's cleaner to select the option at the Kconfig level. > > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > --- > drivers/mtd/nand/Kconfig | 1 + > include/configs/xilinx_zynqmp.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 78a39abf7542..97ec6cf5f9c3 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -123,6 +123,7 @@ endif > > config NAND_ARASAN > bool "Configure Arasan Nand" > + select SYS_NAND_SELF_INIT > imply CMD_NAND > help > This enables Nand driver support for Arasan nand flash > diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h > index 9997fd095982..d883897c6cc2 100644 > --- a/include/configs/xilinx_zynqmp.h > +++ b/include/configs/xilinx_zynqmp.h > @@ -76,7 +76,6 @@ > > #ifdef CONFIG_NAND_ARASAN > # define CONFIG_SYS_MAX_NAND_DEVICE 1 > -# define CONFIG_SYS_NAND_SELF_INIT > # define CONFIG_SYS_NAND_ONFI_DETECTION > # define CONFIG_MTD_DEVICE > #endif > Applied. M
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 78a39abf7542..97ec6cf5f9c3 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -123,6 +123,7 @@ endif config NAND_ARASAN bool "Configure Arasan Nand" + select SYS_NAND_SELF_INIT imply CMD_NAND help This enables Nand driver support for Arasan nand flash diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h index 9997fd095982..d883897c6cc2 100644 --- a/include/configs/xilinx_zynqmp.h +++ b/include/configs/xilinx_zynqmp.h @@ -76,7 +76,6 @@ #ifdef CONFIG_NAND_ARASAN # define CONFIG_SYS_MAX_NAND_DEVICE 1 -# define CONFIG_SYS_NAND_SELF_INIT # define CONFIG_SYS_NAND_ONFI_DETECTION # define CONFIG_MTD_DEVICE #endif
The Arasan NFC driver requires the self-init mode, so it should select it. Instead of having the config header define the macro, it's cleaner to select the option at the Kconfig level. Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> --- drivers/mtd/nand/Kconfig | 1 + include/configs/xilinx_zynqmp.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)