From patchwork Wed Mar 9 05:57:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 86060 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C3D9DB70A4 for ; Wed, 9 Mar 2011 16:57:30 +1100 (EST) Received: (qmail 19738 invoked by alias); 9 Mar 2011 05:57:27 -0000 Received: (qmail 19724 invoked by uid 22791); 9 Mar 2011 05:57:25 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 05:57:21 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id p295vJcZ032564 for ; Tue, 8 Mar 2011 21:57:19 -0800 Received: from iwn33 (iwn33.prod.google.com [10.241.68.97]) by wpaz29.hot.corp.google.com with ESMTP id p295vIKr026660 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 8 Mar 2011 21:57:18 -0800 Received: by iwn33 with SMTP id 33so233215iwn.41 for ; Tue, 08 Mar 2011 21:57:17 -0800 (PST) Received: by 10.231.122.132 with SMTP id l4mr4513616ibr.170.1299650237799; Tue, 08 Mar 2011 21:57:17 -0800 (PST) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id d21sm1238350ibg.15.2011.03.08.21.57.16 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2011 21:57:17 -0800 (PST) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Cc: ro@CeBiTec.Uni-Bielefeld.DE Subject: libgo patch committed: Only run net tests if GCCGO_RUN_ALL_TESTS Date: Tue, 08 Mar 2011 21:57:13 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch to libgo only runs the networking dependent tests if GCCGO_RUN_ALL_TESTS is set in the environment. This is PR 48017. In that PR Rainer suggests having the tests drop back to UNSUPPORTED or UNRESOLVED if they fail to open a network connection. That is tempting but I don't agree with it, because it means that the tests will never fail. It might be better to have some way to test whether the network is available and usable before running the tests. However, that is in itself problematic, as people running all the gcc tests don't necessarily want their machine to start opening network connections. So I think the compromise of requiring an environment variable works well. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 49a9a1dcc2e8 libgo/Makefile.am --- a/libgo/Makefile.am Tue Mar 08 21:28:00 2011 -0800 +++ b/libgo/Makefile.am Tue Mar 08 21:51:48 2011 -0800 @@ -2952,13 +2952,13 @@ fmt/check \ gob/check \ html/check \ - http/check \ + $(if $(GCCGO_RUN_ALL_TESTS),http/check) \ io/check \ json/check \ log/check \ math/check \ mime/check \ - net/check \ + $(if $(GCCGO_RUN_ALL_TESTS),net/check) \ netchan/check \ os/check \ patch/check \ @@ -2974,7 +2974,7 @@ strconv/check \ strings/check \ sync/check \ - syslog/check \ + $(if $(GCCGO_RUN_ALL_TESTS),syslog/check) \ tabwriter/check \ template/check \ time/check \