From patchwork Sat Jan 13 21:39:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerzy Grzegorek X-Patchwork-Id: 860378 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="En5khhCS"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zJtLl19TPz9sBd for ; Sun, 14 Jan 2018 08:39:59 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AFD8687537; Sat, 13 Jan 2018 21:39:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D2D-RH9vnFGH; Sat, 13 Jan 2018 21:39:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id C9C0E8211A; Sat, 13 Jan 2018 21:39:55 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 56DDD1C08AF for ; Sat, 13 Jan 2018 21:39:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 513B72E139 for ; Sat, 13 Jan 2018 21:39:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cbfBocOvhlFl for ; Sat, 13 Jan 2018 21:39:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by silver.osuosl.org (Postfix) with ESMTPS id 008AF2E135 for ; Sat, 13 Jan 2018 21:39:53 +0000 (UTC) Received: by mail-lf0-f66.google.com with SMTP id m8so9437590lfc.6 for ; Sat, 13 Jan 2018 13:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=SBVZD0ONkwJRe8ScaI+2C/MUQG6zn8+16fyer/4Yolg=; b=En5khhCSY2DyPgW1ifrOF0ptQtKkarEzdbjMviOUr55pYwChYEcAtSo5OizJ8LHtzw bNzW6uBQsHofL7ecjWeRlX8mBdZkSQ5NMLHzJgDta+2kU1EbZA8kLk2Afow7gQwlLW3i KqWuqbGF/6cT53pak+kJ7k8DLgq+WGhON7aoNTVBx5TVQdkTjf/UhiFKvj1E0WN4+4Vl qXm30xEverM1p/2Zl87QE47+0sjKNZe2rcgk1XIycdOUwhPgkeklEg1/pY1HuVBT2ORV JB8pabohU+yx9BmPnLYpX5IDcRRe/d1mabFpOsoIrgPELv61w/5KrfIxk3zk7znpdyMD /+Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SBVZD0ONkwJRe8ScaI+2C/MUQG6zn8+16fyer/4Yolg=; b=RsbloBg6Kz605n1U6v16PoYguiM5KRj0Gdm42jUO5XCGsRCAOpqvYflrGnG45oxnJS RJH50ZcJoscuI4sFqjSJRooFhPgJ/QdjaO5hoNpntITNr+38q7IMwHs9dBlyddotOYwp HQNgsVrNOIefG91zxgWICCXI5BIXxYfes0ol7SJA05NdUK05d9rrN2mM9rwaKMOmv2dh 7eKFN4Pxp35qkXjJXDh6Ebb1iy+ADWp64706uTiAvFG5+mbMFOjHtchVP9jYBwmjI3Bn E9zBQgD/oYvtAbT+0EKSXFFpCKWGmrXN2iYsK2RgK3d70ItXlTh/xH+/AbKXRomAZ5gb MJJw== X-Gm-Message-State: AKwxytfeLIiZ+iSEcCrZpenJlZl6+RHk0yfTKV3i3NzuWJhfCUVQbvJ9 EUKA0joABb63hV1fRT8vWiIrkQ== X-Google-Smtp-Source: ACJfBov9YgdvLtPCFtkCfKk0LU57IUgBfv0RppVa4StLX2fv1/o3SANCMVK4A6t+Te0Wsl3KubMpfA== X-Received: by 10.46.95.87 with SMTP id t84mr546762ljb.59.1515879591809; Sat, 13 Jan 2018 13:39:51 -0800 (PST) Received: from localhost.localdomain (93-181-142-99.internetia.net.pl. [93.181.142.99]) by smtp.gmail.com with ESMTPSA id d74sm4780042ljd.71.2018.01.13.13.39.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 13 Jan 2018 13:39:50 -0800 (PST) From: Jerzy Grzegorek To: buildroot@buildroot.org Date: Sat, 13 Jan 2018 22:39:43 +0100 Message-Id: <1515879583-8269-1-git-send-email-jerzy.m.grzegorek@gmail.com> X-Mailer: git-send-email 1.9.1 Subject: [Buildroot] [PATCHv3 1/1] utils/checkpackagelib: add function to check of the default package source variable X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Jerzy Grzegorek , Ricardo Martincoski MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Signed-off-by: Jerzy Grzegorek Cc: Ricardo Martincoski Cc: Thomas Petazzoni Reviewed-by: Ricardo Martincoski Tested-by: Ricardo Martincoski --- Changes v2 -> v3 - add missing whitespaces after ',' (Ricardo Martincoski) - remove value returned by the check function (Ricardo Martincoski) Changes v1 -> v2 - remove unused variable (Ricardo Martincoski) - change warning url (Ricardo Martincoski) - add whitelist of packages (Ricardo Martincoski) utils/checkpackagelib/lib_mk.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 817e809..a6cfeb6 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -99,6 +99,30 @@ class PackageHeader(_CheckFunction): text] +class RemoveDefaultPackageSourceVariable(_CheckFunction): + packages_that_may_contain_default_source = ["binutils", "gcc", "gdb"] + PACKAGE_NAME = re.compile("/([^/]+)\.mk") + + def before(self): + package = self.PACKAGE_NAME.search(self.filename).group(1) + package_upper = package.replace("-", "_").upper() + self.package = package + self.FIND_SOURCE = re.compile( + "^{}_SOURCE\s*=\s*{}-\$\({}_VERSION\)\.tar\.gz" + .format(package_upper, package, package_upper)) + + def check_line(self, lineno, text): + if self.FIND_SOURCE.search(text): + + if self.package in self.packages_that_may_contain_default_source: + return + + return ["{}:{}: remove default value of _SOURCE variable " + "({}#generic-package-reference)" + .format(self.filename, lineno, self.url_to_manual), + text] + + class SpaceBeforeBackslash(_CheckFunction): TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*( |\t)\\$")