From patchwork Tue Mar 8 19:52:55 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 86034 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 18C30B6EE9 for ; Wed, 9 Mar 2011 06:53:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755751Ab1CHTxB (ORCPT ); Tue, 8 Mar 2011 14:53:01 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:55373 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390Ab1CHTw7 (ORCPT ); Tue, 8 Mar 2011 14:52:59 -0500 Received: by eyx24 with SMTP id 24so2169072eyx.19 for ; Tue, 08 Mar 2011 11:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; bh=z2TKIoBNkZ8Ocm9PVBaKBDDB0PeSJVIfSDH3zDWZfk8=; b=fOqFpWqWG5Z4odGqBel3wSFJKdS3OVLXHmWixWyqzrmnJf6+w/4Sk9Dvt1eVNQAorG DJtCoozKFqzZxQ7u6sUgdapbSQ+bVdgqvp1zfHRsUEsgUXLlosFM04maNj4eK7sneLS3 G1GOD5000YEpVRO6eq+pSAOpEOc1My6AOt8sc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=DHfao3gESzBpJ9sE3XwMHCkbpxW+A8QQOCBedoRtvF9eX79bsIc1wX9JxuqID6SN4p mhQe88PeGSKbspk14wvSxOKOkYqbganKxtYf1no1EsYdSV0LxKlHcSgeIrTV2jrCu+Qp VkiY8saTJivtZA31gAEYMaewlYtiIdvsRx388= Received: by 10.14.10.81 with SMTP id 57mr3818695eeu.26.1299613977985; Tue, 08 Mar 2011 11:52:57 -0800 (PST) Received: from [192.168.1.7] (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id b52sm917879eei.13.2011.03.08.11.52.56 (version=SSLv3 cipher=OTHER); Tue, 08 Mar 2011 11:52:56 -0800 (PST) Message-ID: <4D768917.9040605@gmail.com> Date: Tue, 08 Mar 2011 20:52:55 +0100 From: roel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: Wolfgang Grandegger , socketcan-core@lists.berlios.de, netdev@vger.kernel.org, Andrew Morton , LKML Subject: [PATCH] can: wrong index used in inner loop Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Index i was already used in the outer loop. Signed-off-by: Roel Kluin --- drivers/net/can/usb/esd_usb2.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c index 05a5275..dc53c83 100644 --- a/drivers/net/can/usb/esd_usb2.c +++ b/drivers/net/can/usb/esd_usb2.c @@ -659,7 +659,7 @@ failed: static void unlink_all_urbs(struct esd_usb2 *dev) { struct esd_usb2_net_priv *priv; - int i; + int i, j; usb_kill_anchored_urbs(&dev->rx_submitted); for (i = 0; i < dev->net_count; i++) { @@ -668,8 +668,8 @@ static void unlink_all_urbs(struct esd_usb2 *dev) usb_kill_anchored_urbs(&priv->tx_submitted); atomic_set(&priv->active_tx_jobs, 0); - for (i = 0; i < MAX_TX_URBS; i++) - priv->tx_contexts[i].echo_index = MAX_TX_URBS; + for (j = 0; j < MAX_TX_URBS; j++) + priv->tx_contexts[j].echo_index = MAX_TX_URBS; } } }