Patchwork can: wrong index used in inner loop

login
register
mail settings
Submitter roel kluin
Date March 8, 2011, 7:52 p.m.
Message ID <4D768917.9040605@gmail.com>
Download mbox | patch
Permalink /patch/86034/
State Accepted
Delegated to: David Miller
Headers show

Comments

roel kluin - March 8, 2011, 7:52 p.m.
Index i was already used in the outer loop.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 drivers/net/can/usb/esd_usb2.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 14, 2011, 9:47 p.m.
From: roel <roel.kluin@gmail.com>
Date: Tue, 08 Mar 2011 20:52:55 +0100

> Index i was already used in the outer loop.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

CAN maintainers, could you please review and ACK patches in a timely manner,
especially utterly trivial bug fixes like this one here?

That's largely what I've been waiting for, a simple sign of life from the
listed maintainers for these files.

Anyways, no use waiting any longer, applied, thanks Roel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfgang Grandegger - March 15, 2011, 9:02 a.m.
On Mon, 14 Mar 2011 14:47:43 -0700 (PDT), David Miller
<davem@davemloft.net> wrote:
> From: roel <roel.kluin@gmail.com>
> Date: Tue, 08 Mar 2011 20:52:55 +0100
> 
>> Index i was already used in the outer loop.
>> 
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> 
> CAN maintainers, could you please review and ACK patches in a timely
> manner,
> especially utterly trivial bug fixes like this one here?
> 
> That's largely what I've been waiting for, a simple sign of life from
the
> listed maintainers for these files.

OK, will try to react fast next time.

> Anyways, no use waiting any longer, applied, thanks Roel.

Thanks,

Wolfgang.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index 05a5275..dc53c83 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -659,7 +659,7 @@  failed:
 static void unlink_all_urbs(struct esd_usb2 *dev)
 {
 	struct esd_usb2_net_priv *priv;
-	int i;
+	int i, j;
 
 	usb_kill_anchored_urbs(&dev->rx_submitted);
 	for (i = 0; i < dev->net_count; i++) {
@@ -668,8 +668,8 @@  static void unlink_all_urbs(struct esd_usb2 *dev)
 			usb_kill_anchored_urbs(&priv->tx_submitted);
 			atomic_set(&priv->active_tx_jobs, 0);
 
-			for (i = 0; i < MAX_TX_URBS; i++)
-				priv->tx_contexts[i].echo_index = MAX_TX_URBS;
+			for (j = 0; j < MAX_TX_URBS; j++)
+				priv->tx_contexts[j].echo_index = MAX_TX_URBS;
 		}
 	}
 }