From patchwork Fri Jan 12 17:45:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Sun X-Patchwork-Id: 860224 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nHEBXkNJ"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zJHxL12bHz9ryr for ; Sat, 13 Jan 2018 09:49:25 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 0BEFCF9F; Fri, 12 Jan 2018 22:49:23 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 751A9F64 for ; Fri, 12 Jan 2018 22:49:22 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3365D44D for ; Fri, 12 Jan 2018 22:49:22 +0000 (UTC) Received: by mail-pf0-f196.google.com with SMTP id i66so5438264pfd.7 for ; Fri, 12 Jan 2018 14:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FF3OH9TBxqxiCJgUJMk80lqJEU1Vx0oSQrxidapQTrI=; b=nHEBXkNJhaCZ85+4HTkMrrs1FkAcYzOkpHro8SWg8+d0FLQPdZTu8D4tJCspUjC8or fQMczM+7OcAhZ8HZ07XI9rsbi4rvGXF26YlSvbVR92afr7Sab8ey4wA5ICX4hR/b4pii bzQ9/4tEDgX3O1X/zZJK0d5tTJYDfkyxu8VzPSjtZXP/d0MDpEwiFpdfCCfe8iWKfptq 4xobHJzzEQUMrLmAwAr9YwHmdEXQPjL3LKlgczkJPXHFFmzogKSehrM4gI2HZsE+Xzlr QD4qnIkkdS/bUiZxznqpU5oJeR7OH2MxTDMWqP03WrZOBvZXSBVL1UWb3gleOFXr7zLs ylCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FF3OH9TBxqxiCJgUJMk80lqJEU1Vx0oSQrxidapQTrI=; b=iEz23mXsoziYdtGbspm9zDDDWylylS/5c60WCIOa/iBdr5H1jkGL1wcu659WB7WrGE DOgvSW1DC8vDmtMLqQJYU9DwDNHGlku1wQw8whhZbVlMM3UkM8ybRPnjMTl1GT7+UEXI ECGBQHRdeSi7VyP3mI4wqTqzBSY/RL/hm90+VFW/tz8z/HOCHptqb/Ok0aGkjimSmaob 7ao5Tu3PMTJp9yKizR1t1M7ebJarvsa8KTSRCDHcRdUdZtwZXQVBEJes8GvY4Faylfwl 98XgbTfAnXd8P1mKXbb2WHqyzY17gyolno23Yjc5F9T8cmo3ecyJQbDlL2eRAfIsnmBs GV+w== X-Gm-Message-State: AKGB3mKho0i2xktUCeQH2kMQ8SAmFKgRXUeLrBof1vmOxrQ3ctmg/mNY hih/WQ2alBFnZR0hcHyGyy0wew== X-Google-Smtp-Source: ACJfBouGDSQsqWf0DIdqpQDz2SATEJoeEbFi0D5kLdtlggRXnygU+NwaBAk9hq8ZCog5P1AOSnQFOg== X-Received: by 10.159.195.3 with SMTP id bd3mr28262002plb.426.1515797361574; Fri, 12 Jan 2018 14:49:21 -0800 (PST) Received: from yfsovs.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id g15sm8818600pgu.52.2018.01.12.14.49.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Jan 2018 14:49:21 -0800 (PST) From: Yifeng Sun To: dev@openvswitch.org Date: Fri, 12 Jan 2018 09:45:30 -0800 Message-Id: <1515779132-28902-2-git-send-email-pkusunyifeng@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515779132-28902-1-git-send-email-pkusunyifeng@gmail.com> References: <1515779132-28902-1-git-send-email-pkusunyifeng@gmail.com> X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00, DATE_IN_PAST_03_06, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 2/4] ovn-northd: Fix memory leak X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This leak was reported by valgrind (testing ovn -- IPv6 Neighbor Solicitation for unknown MAC): 3,027 bytes in 49 blocks are definitely lost in loss record 210 of 218 by 0x484C84: xrealloc (util.c:131) by 0x43CE41: ds_reserve (dynamic-string.c:63) by 0x43D29D: ds_put_format_valist (dynamic-string.c:161) by 0x43D3A3: ds_put_format (dynamic-string.c:142) by 0x412EEF: ovn_port_update_sbrec (ovn-northd.c:1948) by 0x4148B4: build_ports (ovn-northd.c:2109) by 0x4148B4: ovnnb_db_run.isra.37 (ovn-northd.c:6202) by 0x406FE0: main (ovn-northd.c:6854) Signed-off-by: Yifeng Sun --- ovn/northd/ovn-northd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 63ed97e..902392f 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -1949,6 +1949,7 @@ ovn_port_update_sbrec(struct northd_context *ctx, } const char *addresses = ds_cstr(&s); sbrec_port_binding_set_mac(op->sb, &addresses, 1); + ds_destroy(&s); struct smap ids = SMAP_INITIALIZER(&ids); sbrec_port_binding_set_external_ids(op->sb, &ids);