From patchwork Thu Jan 11 13:52:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 859135 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-470836-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="i/QiKBd/"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHS3w5lVrz9sNV for ; Fri, 12 Jan 2018 00:52:11 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=Tmtx/lNC8fAZ7C1VkyVVrvWZeKpdMgr3Wv06OJBtFYQHmz06an IUfxLSkUDdtnET+0EOFDccm++7apRH3Be7uetPw2/hZpXCB4+bU9V08+y19gQWSO cDSq7v/i1NUXnd9XKvto9TUc+sgclIwFA7S+oPEVxeZDZquzHd+LdCYM8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=F2mb8d/fRJEZhS4gZvdw2sPM5qI=; b=i/QiKBd/RHyJ6d+L92G+ pKHY/rXMucIni5gsasiBrlDWQfGE+lxFoTKlLwX+UiuOFgl1vgaqlAVPQXLvGtAl f/DSudWT/x1B9cqRY6Te69r1pUDPurlatOIOQmNWiWz5t/0OPPClciJzdxUPmTi3 IvlYlxD1qxPfZLviG+XSUEc= Received: (qmail 13067 invoked by alias); 11 Jan 2018 13:52:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13013 invoked by uid 89); 11 Jan 2018 13:52:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=alerted, H*UA:https X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jan 2018 13:52:03 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 799D8ADD3 for ; Thu, 11 Jan 2018 13:52:01 +0000 (UTC) From: Martin Jambor To: GCC Patches Cc: Jan Hubicka Subject: [PR 83178] Adjust scan-dump-times count of devirt-22.C User-Agent: Notmuch/0.25.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-suse-linux-gnu) Date: Thu, 11 Jan 2018 14:52:00 +0100 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi, IPA-CP does an extra devirtualization in devirt-22.C now because Honza's profiling changes have caused an extra edge to be maybe_hot_p. The scan dump is guarded with scan-dump-times, I assume so that we are alerted to any changes in behavior of the patch, like now. I have looked at the behavior of IPA-CP and also reviewed the new profile info, which seems better or at least not worse than before (more info in my comment to the bug) and therefore I would like to propose to adjust the test dump scan expected count in the patch below. OK for trunk? Thanks, Martin 2018-01-11 Martin Jambor PR ipa/83178 * g++.dg/ipa/devirt-22.C: Adjust scan-dump-times count. diff --git a/gcc/testsuite/g++.dg/ipa/devirt-22.C b/gcc/testsuite/g++.dg/ipa/devirt-22.C index 0201f34eade..7ec4f436145 100644 --- a/gcc/testsuite/g++.dg/ipa/devirt-22.C +++ b/gcc/testsuite/g++.dg/ipa/devirt-22.C @@ -37,4 +37,4 @@ void update_sources() { /* Note that we miss one devirtualization because we are not able to track the vtbl store in destructor. Previously we devirtualized to C::m_fn1 instead of B::m_fn1. */ -/* { dg-final { scan-ipa-dump-times "Discovered a virtual call to a known target" 1 "cp" } } */ +/* { dg-final { scan-ipa-dump-times "Discovered a virtual call to a known target" 2 "cp" } } */