[PR,83178] Adjust scan-dump-times count of devirt-22.C

Message ID ri6efmw1p1b.fsf@suse.cz
State New
Headers show
Series
  • [PR,83178] Adjust scan-dump-times count of devirt-22.C
Related show

Commit Message

Martin Jambor Jan. 11, 2018, 1:52 p.m.
Hi,

IPA-CP does an extra devirtualization in devirt-22.C now because Honza's
profiling changes have caused an extra edge to be maybe_hot_p.  The scan
dump is guarded with scan-dump-times, I assume so that we are alerted to
any changes in behavior of the patch, like now.

I have looked at the behavior of IPA-CP and also reviewed the new
profile info, which seems better or at least not worse than before (more
info in my comment to the bug) and therefore I would like to propose to
adjust the test dump scan expected count in the patch below.

OK for trunk?

Thanks,

Martin


2018-01-11  Martin Jambor  <mjambor@suse.cz>

	PR ipa/83178
	* g++.dg/ipa/devirt-22.C: Adjust scan-dump-times count.

Comments

Jeff Law Jan. 11, 2018, 3:56 p.m. | #1
On 01/11/2018 06:52 AM, Martin Jambor wrote:
> Hi,
> 
> IPA-CP does an extra devirtualization in devirt-22.C now because Honza's
> profiling changes have caused an extra edge to be maybe_hot_p.  The scan
> dump is guarded with scan-dump-times, I assume so that we are alerted to
> any changes in behavior of the patch, like now.
> 
> I have looked at the behavior of IPA-CP and also reviewed the new
> profile info, which seems better or at least not worse than before (more
> info in my comment to the bug) and therefore I would like to propose to
> adjust the test dump scan expected count in the patch below.
> 
> OK for trunk?
> 
> Thanks,
> 
> Martin
> 
> 
> 2018-01-11  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR ipa/83178
> 	* g++.dg/ipa/devirt-22.C: Adjust scan-dump-times count.
THanks.  I went ahead and installed.

jeff

Patch

diff --git a/gcc/testsuite/g++.dg/ipa/devirt-22.C b/gcc/testsuite/g++.dg/ipa/devirt-22.C
index 0201f34eade..7ec4f436145 100644
--- a/gcc/testsuite/g++.dg/ipa/devirt-22.C
+++ b/gcc/testsuite/g++.dg/ipa/devirt-22.C
@@ -37,4 +37,4 @@  void update_sources() {
 /* Note that we miss one devirtualization because we are not able to track the
    vtbl store in destructor.  
    Previously we devirtualized to C::m_fn1 instead of B::m_fn1.  */
-/* { dg-final { scan-ipa-dump-times "Discovered a virtual call to a known target" 1 "cp"  } } */
+/* { dg-final { scan-ipa-dump-times "Discovered a virtual call to a known target" 2 "cp"  } } */