[v1,3/4] ARM: dts: add pwm pins for r40.

Message ID 20180111113323.GA21976@arx-s1
State Superseded
Headers show
Series
  • pwm support for allwinner sun8i R40/V40/T3 SOCs.
Related show

Commit Message

Hao Zhang Jan. 11, 2018, 11:33 a.m.
This patch add pwm pins for r40.

Signed-off-by: hao_zhang <hao5781286@gmail.com>
---
 arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Maxime Ripard Jan. 11, 2018, 12:47 p.m. | #1
Hi,

On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
> This patch add pwm pins for r40.
> 
> Signed-off-by: hao_zhang <hao5781286@gmail.com>

You should order your patches differently. We try to be as bisectable
as possible, and if we just apply this patch the DT will not compile
anymore.

Your patch 4 should come before this one.

Your commit title and log doesn't seem to match the content of the
patch either.

Thanks!
Maxime
Hao Zhang Jan. 14, 2018, 7:07 a.m. | #2
2018-01-11 20:47 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> Hi,
>
> On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
>> This patch add pwm pins for r40.
>>
>> Signed-off-by: hao_zhang <hao5781286@gmail.com>
>
> You should order your patches differently. We try to be as bisectable
> as possible, and if we just apply this patch the DT will not compile
> anymore.
>
> Your patch 4 should come before this one.
>

Do you mean that the order of patch be applied is from the first to
the last in the patch set ?
because you apply the last patch first also break the DT compile...

Thinks :)
Hao Zhang

> Your commit title and log doesn't seem to match the content of the
> patch either.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Maxime Ripard Jan. 15, 2018, 8:39 a.m. | #3
On Sun, Jan 14, 2018 at 03:07:46PM +0800, Hao Zhang wrote:
> 2018-01-11 20:47 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
> >> This patch add pwm pins for r40.
> >>
> >> Signed-off-by: hao_zhang <hao5781286@gmail.com>
> >
> > You should order your patches differently. We try to be as bisectable
> > as possible, and if we just apply this patch the DT will not compile
> > anymore.
> >
> > Your patch 4 should come before this one.
> >
> 
> Do you mean that the order of patch be applied is from the first to
> the last in the patch set ?

Yes and each steps should compile and not introduce any regressions
(ideally :)).

Thanks!
Maxime

Patch

diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
index 8c5efe2..6cf6273 100644
--- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
@@ -196,6 +196,12 @@ 
 	status = "okay";
 };
 
+&pwm {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pwm_pins>;
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pb_pins>;