From patchwork Thu Jan 11 09:15:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 858962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-470809-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="icDBbFB3"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHKym5pK1z9t3h for ; Thu, 11 Jan 2018 20:17:20 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=DPMaHBKu9Kgn7iqBl2XNaMFDU5e6BTh6lYj59+w8sCkfQgYnZi +iuTGqjnWp0KC3G/eaAPRMU7hDE5vmXkRe41Isi1UY4i4E2oZetRADbWRgdD+xtT 5nL9fKT18e7xEvs3awAX41UmLUjk0BluGV+OFEuibC9itP8d7j4MuTKCA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=sLH801NCgOcD3a3yf2bjNqKZP34=; b=icDBbFB3fBhAstgsm5XY WRL062mXhBluO8HRiWfCObzpfwgLqWGRM7NiaFET4fFY2C0A2goKl7zblJEE5PET Rsd388s8VNTQkGdjhQmql4DCdP7v28cJa0VZUs03+TlUxo/aUyTKDEicPhaKcPID FlWyoLAiTdALh5gOA+Qqe74= Received: (qmail 21816 invoked by alias); 11 Jan 2018 09:16:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21140 invoked by uid 89); 11 Jan 2018 09:15:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Gary, 60527, gary X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jan 2018 09:15:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EE235117BC4; Thu, 11 Jan 2018 04:15:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dPMM0-Z1nTTd; Thu, 11 Jan 2018 04:15:38 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id DDB68117BBE; Thu, 11 Jan 2018 04:15:38 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4862) id DC66C50B; Thu, 11 Jan 2018 04:15:38 -0500 (EST) Date: Thu, 11 Jan 2018 04:15:38 -0500 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Gary Dismukes Subject: [Ada] Warning on out-of-range value for default-initialized scalar object Message-ID: <20180111091538.GA105733@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes When an object of a type with a specified Default_Value aspect is declared without an explicit initial value and the default value is out of range of the objects subtype, the compiler now issues a warning that Constraint_Error will be raised due to an out-of-range value. The test below must output a compiler warning as follows: $ gcc -c -gnatj70 default_warning.adb default_warning.adb:7:08: warning: value not in range of type "Subint" defined at line 5, "Constraint_Error" will be raised at run time procedure Default_Warning is type Int_With_Default is new Integer with Default_Value => 0; subtype Subint is Int_With_Default range 1 .. 100; S : Subint; begin null; end Default_Warning; Tested on x86_64-pc-linux-gnu, committed on trunk 2018-01-11 Gary Dismukes gcc/ada/ * exp_ch3.adb (Default_Initialize_Object): Call New_Copy_Tree on the result of Get_Simple_Init_Value and pass the source location of the object declaration's object_definition. --- gcc/ada/exp_ch3.adb +++ gcc/ada/exp_ch3.adb @@ -6052,7 +6052,10 @@ package body Exp_Ch3 is and then not Has_Init_Expression (N) then Set_No_Initialization (N, False); - Set_Expression (N, Get_Simple_Init_Val (Typ, N, Esize (Def_Id))); + Set_Expression + (N, New_Copy_Tree + (Get_Simple_Init_Val (Typ, N, Esize (Def_Id)), + New_Sloc => Sloc (Obj_Def))); Analyze_And_Resolve (Expression (N), Typ); end if;