[Ada] Missing diagnostic of categorization dependency

Message ID 20180111091259.GA105244@adacore.com
State New
Headers show
Series
  • [Ada] Missing diagnostic of categorization dependency
Related show

Commit Message

Pierre-Marie de Rodat Jan. 11, 2018, 9:12 a.m.
This patch modifies the analysis of subprogram bodies to catch a case where a
pure subprogram body unit depends on non-pure units.

Tested on x86_64-pc-linux-gnu, committed on trunk

2018-01-11  Hristian Kirtchev  <kirtchev@adacore.com>

gcc/ada/

	* sem_ch6.adb (Analyze_Subprogram_Body_Helper): Check the
	categorization of a subprogram body which does not complete a previous
	declaration.

gcc/testsuite/

	* gnat.dg/pure_subp_body.adb, gnat.dg/pure_subp_body_pkg.ads: New
	testcase.

Patch

--- gcc/ada/sem_ch6.adb
+++ gcc/ada/sem_ch6.adb
@@ -6,7 +6,7 @@ 
 --                                                                          --
 --                                 B o d y                                  --
 --                                                                          --
---          Copyright (C) 1992-2017, Free Software Foundation, Inc.         --
+--          Copyright (C) 1992-2018, Free Software Foundation, Inc.         --
 --                                                                          --
 -- GNAT is free software;  you can  redistribute it  and/or modify it under --
 -- terms of the  GNU General Public License as published  by the Free Soft- --
@@ -4463,6 +4463,12 @@  package body Sem_Ch6 is
             Set_First_Entity (Spec_Id, Empty);
             Set_Last_Entity  (Spec_Id, Empty);
          end if;
+
+      --  Otherwise the body does not complete a previous declaration. Check
+      --  the categorization of the body against the units it withs.
+
+      else
+         Validate_Categorization_Dependency (N, Body_Id);
       end if;
 
       Check_Missing_Return;--- /dev/null
new file mode 100644
+++ gcc/testsuite/gnat.dg/pure_subp_body.adb
@@ -0,0 +1,12 @@ 
+--  { dg-do compile }
+
+with Pure_Subp_Body_Pkg;
+
+procedure Pure_Subp_Body with Pure is
+begin
+    null;
+end Pure_Subp_Body;
+
+--  cannot depend on "Pure_Subp_Body_Pkg" (wrong categorization)
+--  { dg-error "cannot depend on \"Pure_Subp_Body_Pkg\" \\(wrong categorization\\)" "" { target *-*-* } 3 }
+--  { dg-error "pure unit cannot depend on non-pure unit" "non-pure unit" { target *-*-* } 3 }--- /dev/null
new file mode 100644
+++ gcc/testsuite/gnat.dg/pure_subp_body_pkg.ads
@@ -0,0 +1,2 @@ 
+package Pure_Subp_Body_Pkg is
+end Pure_Subp_Body_Pkg;