From patchwork Thu Jan 11 08:35:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 858920 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zHK4k3Rfsz9t3w for ; Thu, 11 Jan 2018 19:37:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932449AbeAKIhL (ORCPT ); Thu, 11 Jan 2018 03:37:11 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:56910 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932220AbeAKIhJ (ORCPT ); Thu, 11 Jan 2018 03:37:09 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MP0FD-1eTFc70HWJ-006SNa; Thu, 11 Jan 2018 09:36:08 +0100 From: Arnd Bergmann To: Linus Walleij Cc: Arnd Bergmann , William Breathitt Gray , Guenter Roeck , "Maciej S . Szmigiero" , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: winbond: fix ISA_BUS_API dependency Date: Thu, 11 Jan 2018 09:35:15 +0100 Message-Id: <20180111083600.4121805-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:bQUbQekLkebL/gVsjxk/AkRYmwdjLICVSBV2MVXPDTpZNC+yVqx Lm9c7EwdoIkXA2EkcupF5zy1TtmBUH14g7nNkS8qqj76fCAjflQbAJnaKRfGWChBgtdKeY9 SuWc0VQ4oiq84HEml7izt9PZL5kbx0lgbNSCdkWw8Iql+c3k1egVJDs04w3xChbQ8pxve8u SRQ1Gh1j+LuCZb5UnqsBw== X-UI-Out-Filterresults: notjunk:1; V01:K0:lvkt7kc8p2k=:M2y26ro0kaQOO+8EhM76Zs 6VRtWbcxC0xrcXpbD0VWJ7fnK4Y4Glvkg93ZrV7pRfLVn9Jpru/Om6ou1ALXnSRogX/iA1UQr t6iJSHfwXl41KQVg5XOQeHCoPXykQxlEk4r/XiOaH2wT+oK1TSKiYrwHfV4y4ld+NR+9JCAXQ xfT9aVKNr3tySFRuZuLHM6eKq9FbR0PNvlWYl+Z+FUYqdfdOx8pcgSNJyC2sXGBYio+ua1D2E dTBLmvRsq2j0AepBnABfBe+zkJiEcPBQ6C3MBSVVPdATUZNG/20mgj7B0vvhJj0C2wz8zLmVP Ek9n5NO3uaTm1rjGDAHjVU55srKos165wKecQyxW0LhRmex+Lu6IqPrRaHKc4rd7pDhOkfg0G uY6dbzaEMLk/DZQ3nlEv94mJ7eZ6ufpg3tNjOnc61ungg6Lqpwk/p1phv4LK3Qpb+Eqh2cvrb aAWLpd7Jo8qzV4Y4a7JfSt191afc3sonmA5coW/JaGDxVvc4DVm1Pc4M8s7XdGX4v9/NJl0sA WHttgu6GkBNmqm9QbHiXr4M3r7dP/W2ofyigFZjjfhbf+IkRv7rwoiZaU3VUxuAVv6UoUFXel 8iSZ8awMSdrtOLc/G+KhEzRxCaHI4hf7MVf5LDUHewXiP+spgqZjuQUFeSV9wYb2ggA/Di69I bUnE2tVS/phZ8rtqArA1K1euHICL3c2vwtQ7+jQOSdulV+ZyGWPs1eA11ThW4AEszlNo+Ol1+ I4B9IKyLaAph9oRuf4UsKCU/qvPbCxsXtqGwJA== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The newly added GPIO driver for winbond chipsets causes a circular dependency warning in Kconfig: drivers/gpio/Kconfig:13:error: recursive dependency detected! drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by STX104 drivers/iio/adc/Kconfig:699: symbol STX104 depends on ISA_BUS_API arch/Kconfig:830: symbol ISA_BUS_API is selected by GPIO_WINBOND drivers/gpio/Kconfig:701: symbol GPIO_WINBOND depends on GPIOLIB The underlying problem is that ISA_BUS_API is not meant to be selected by device drivers, instead it is provided by the architectures that support ISA add-on card devices, or in case of x86 have this explicitly enabled. This particular driver appears to be different from the other ISA_BUS_API based drivers, in that it is not normally an add-on card (ISA or PC104) but instead is an LPC-attached component on the mainboard. We already support other functionality provided by this chip, at least drivers/watchdog/w83627hf_wdt.c and drivers/hwmon/w83627ehf.c, plus there is a discovery function for this hardware in drivers/parport/parport_pc.c. If we want to use this driver without having to enable CONFIG_EXPERT, it might be better to not use the isa_bus_type for it, but rather turn it into a platform_driver, acpi_driver or add an MFD for it that is shared with the wdt and hwmon portions and does the probing. For now, this patch fixes the dependency by changing 'select' into 'depends on'. Cc: William Breathitt Gray Cc: Guenter Roeck Cc: Maciej S. Szmigiero Cc: Andy Shevchenko Fixes: a0d65009411c ("gpio: winbond: Add driver") Signed-off-by: Arnd Bergmann --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 440af077cc76..8dbb2280538d 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -700,7 +700,7 @@ config GPIO_TS5500 config GPIO_WINBOND tristate "Winbond Super I/O GPIO support" - select ISA_BUS_API + depends on ISA_BUS_API help This option enables support for GPIOs found on Winbond Super I/O chips.