diff mbox series

ubifs: Change log level in ubifs_xattr_get

Message ID 1515578741-6612-1-git-send-email-rockdotlee@gmail.com
State Superseded
Delegated to: Richard Weinberger
Headers show
Series ubifs: Change log level in ubifs_xattr_get | expand

Commit Message

Rock Lee Jan. 10, 2018, 10:05 a.m. UTC 
From: Rock Lee <rockdotlee@gmail.com>

Just print warning message when xattr value size is bigger than the
buffer size. There is a situation that other modules, like overlayfs,
try to get xattr value with a small buffer, if they get -ERANGE, they
will try again with the proper buffer size. No need to report a error
message, warning message is enough.

Signed-off-by: Rock Lee <rockdotlee@gmail.com>
---
 fs/ubifs/xattr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger Jan. 10, 2018, 2:39 p.m. UTC | #1 
Rock Lee,

Am Mittwoch, 10. Januar 2018, 11:05:41 CET schrieb rockdotlee@gmail.com:
> From: Rock Lee <rockdotlee@gmail.com>
> 
> Just print warning message when xattr value size is bigger than the
> buffer size. There is a situation that other modules, like overlayfs,
> try to get xattr value with a small buffer, if they get -ERANGE, they
> will try again with the proper buffer size. No need to report a error
> message, warning message is enough.
> 
> Signed-off-by: Rock Lee <rockdotlee@gmail.com>
> ---
>  fs/ubifs/xattr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
> index 5ddc89d..bc20530 100644
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -381,7 +381,7 @@ ssize_t ubifs_xattr_get(struct inode *host, const char
> *name, void *buf, if (buf) {
>  		/* If @buf is %NULL we are supposed to return the length */
>  		if (ui->data_len > size) {
> -			ubifs_err(c, "buffer size %zd, xattr len %d",
> +			ubifs_warn(c, "buffer size %zd, xattr len %d",
>  				  size, ui->data_len);

Hmm, if this can be triggered that easy I suggest getting completely rid of 
this message.

Thanks,
//richard
Rock Lee Jan. 11, 2018, 1:47 a.m. UTC | #2 
>> Just print warning message when xattr value size is bigger than the
>> buffer size. There is a situation that other modules, like overlayfs,
>> try to get xattr value with a small buffer, if they get -ERANGE, they
>> will try again with the proper buffer size. No need to report a error
>> message, warning message is enough.
>>
>> Signed-off-by: Rock Lee <rockdotlee@gmail.com>
>> ---
>>  fs/ubifs/xattr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
>> index 5ddc89d..bc20530 100644
>> --- a/fs/ubifs/xattr.c
>> +++ b/fs/ubifs/xattr.c
>> @@ -381,7 +381,7 @@ ssize_t ubifs_xattr_get(struct inode *host, const char
>> *name, void *buf, if (buf) {
>>               /* If @buf is %NULL we are supposed to return the length */
>>               if (ui->data_len > size) {
>> -                     ubifs_err(c, "buffer size %zd, xattr len %d",
>> +                     ubifs_warn(c, "buffer size %zd, xattr len %d",
>>                                 size, ui->data_len);
>
> Hmm, if this can be triggered that easy I suggest getting completely rid of
> this message.
>

OK, forget about this one, I am going to send you another patch to get
rid of this message
diff mbox series

Patch

diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
index 5ddc89d..bc20530 100644
--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -381,7 +381,7 @@  ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
 	if (buf) {
 		/* If @buf is %NULL we are supposed to return the length */
 		if (ui->data_len > size) {
-			ubifs_err(c, "buffer size %zd, xattr len %d",
+			ubifs_warn(c, "buffer size %zd, xattr len %d",
 				  size, ui->data_len);
 			err = -ERANGE;
 			goto out_iput;