[OpenWrt-Devel,RFC,1/2] downloads.mk: introduce name-agnostic PROJECT_GIT variable

Message ID 20180105095341.9547-1-jo@mein.io
State RFC
Headers show
Series
  • [OpenWrt-Devel,RFC,1/2] downloads.mk: introduce name-agnostic PROJECT_GIT variable
Related show

Commit Message

Jo-Philipp Wich Jan. 5, 2018, 9:53 a.m.
Introduce a name-agnostic PROJECT_GIT variable poiting to
https://git.openwrt.org/ and declare LEDE_GIT and OPENWRT_GIT
as aliases to it.

After some transition time we can drop this alias variables.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---
 include/download.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jonas Gorski Jan. 5, 2018, 10:16 a.m. | #1
On 5 January 2018 at 10:53, Jo-Philipp Wich <jo@mein.io> wrote:
> Introduce a name-agnostic PROJECT_GIT variable poiting to
> https://git.openwrt.org/ and declare LEDE_GIT and OPENWRT_GIT
> as aliases to it.
>
> After some transition time we can drop this alias variables.
>
> Signed-off-by: Jo-Philipp Wich <jo@mein.io>

Generally looks good, but we should defer it until the old
git.openwrt.org entry got purged from dns caches (which is still like
4 or 5 days or so?)


Regards
Jonas

Patch

diff --git a/include/download.mk b/include/download.mk
index 0a25641738..2ba8a7bdf4 100644
--- a/include/download.mk
+++ b/include/download.mk
@@ -6,8 +6,10 @@ 
 # See /LICENSE for more information.
 #
 
-OPENWRT_GIT = http://git.openwrt.org
-LEDE_GIT = https://git.lede-project.org
+PROJECT_GIT = https://git.openwrt.org
+
+OPENWRT_GIT = $(PROJECT_GIT)
+LEDE_GIT = $(PROJECT_GIT)
 
 ifdef PKG_SOURCE_VERSION
 PKG_VERSION ?= $(if $(PKG_SOURCE_DATE),$(PKG_SOURCE_DATE)-)$(call version_abbrev,$(PKG_SOURCE_VERSION))