| Message ID | 7f363f90-edb1-f7e6-90e0-b1c4421497db@lundman.net |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,GIT,PULL] ZFS: lundman/master | expand |
On Wed, Jan 10, 2018 at 12:21:32PM +0900, Jorgen Lundman wrote: > > Hello, > I didn't hear back about the changes, so I'll proceed to this stage. :) > Please find additional ZFS boot features, and fixes. Please advise if > outside git repositories are not allowed. > > The following changes since commit ab61e175713a0400c6ece6348e8f655998cf574d: > > ARM: rmobile: Rework the ULCB CPLD driver (Sun Nov 26 20:32:44 2017 +0100) > > are available in the git repository at: > > https://github.com/lundman/u-boot.git master > > for you to fetch changes up to c2727e5004fe011d19156d728babdf968515b28d: > > Update ZFS support to latest (Thu Dec 7 16:09:26 2017 +0900) > ---------------------------------------------------------------- > Jorgen Lundman (1): > Update ZFS support to latest > > cmd/zfs.c | 22 +- > fs/zfs/Makefile | 4 +- > fs/zfs/dev.c | 20 +- > fs/zfs/zfs.c | 3223 +++++++++++++++++++++++++++++++----------- > fs/zfs/zfs_fletcher.c | 6 +- > fs/zfs/zfs_lz4.c | 286 ++++ > fs/zfs/zfs_sha256.c | 14 +- > include/zfs/dmu.h | 48 +- > include/zfs/sa_impl.h | 5 +- > include/zfs/spa.h | 18 + > include/zfs/uberblock_impl.h | 15 +- > include/zfs/zap_leaf.h | 4 +- > include/zfs/zfs.h | 22 +- > include/zfs/zio.h | 9 +- > include/zfs_common.h | 27 +- > 15 files changed, 2819 insertions(+), 904 deletions(-) I'm reluctant to just take this as-is. That's a lot of code changes in a single commit that was not posted (as far as I can see) to the mailing list. Can you break that down into a series of changes that can be reviewed and post that? Thanks!
> > I'm reluctant to just take this as-is. That's a lot of code changes in > a single commit that was not posted (as far as I can see) to the mailing > list. Can you break that down into a series of changes that can be > reviewed and post that? Thanks! > I received an email that ZFS U-boot booting was tricky to get to work, since it required old pool version, and didn't work at all with big endian. When I first did ZFS, I took the GRUB sources in 2012. So this time around, I collected the commits from 2012 to now, and merged them into u-boot. Some ~50 commits or so. It makes U-boot work with modern pools, and current default compression (lz4) as well as raidz/mirror boots. It is a large change, I agree. But I'm unsure how to split it into smaller commits. It is mostly bring it up to current with its upstream. If it is preferred to post to the ML, I will do so - I thought "git pull" was an alternate. Please advice, Lund
On Thu, Jan 11, 2018 at 09:12:04AM +0900, Jorgen Lundman wrote: > > > > I'm reluctant to just take this as-is. That's a lot of code changes in > > a single commit that was not posted (as far as I can see) to the mailing > > list. Can you break that down into a series of changes that can be > > reviewed and post that? Thanks! > > > > I received an email that ZFS U-boot booting was tricky to get to work, > since it required old pool version, and didn't work at all with big endian. > > When I first did ZFS, I took the GRUB sources in 2012. So this time around, > I collected the commits from 2012 to now, and merged them into u-boot. Some > ~50 commits or so. It makes U-boot work with modern pools, and current > default compression (lz4) as well as raidz/mirror boots. > > It is a large change, I agree. But I'm unsure how to split it into smaller > commits. It is mostly bring it up to current with its upstream. > > If it is preferred to post to the ML, I will do so - I thought "git pull" > was an alternate. Please advice, OK, so I took a look at https://github.com/lundman/u-boot/commit/c2727e5004fe011d19156d728babdf968515b28d and here's my comments: - You're missing the Signed-off-by line - You should mention the starting / ending revisions of your sync of the code from GRUB. - fs/zfs/zfs_lz4.c needs to use an SPDX tag. - You've got some changes that change the Copyright year from 2012 to 2018, when it should be 2012-2018 And finally, it's not so large that you can't post the patch to the ML for additional reviews and I'll pick it up and apply it directly. Thanks!
Hello, I didn't hear back about the changes, so I'll proceed to this stage. :) Please find additional ZFS boot features, and fixes. Please advise if outside git repositories are not allowed. The following changes since commit ab61e175713a0400c6ece6348e8f655998cf574d: ARM: rmobile: Rework the ULCB CPLD driver (Sun Nov 26 20:32:44 2017 +0100) are available in the git repository at: https://github.com/lundman/u-boot.git master for you to fetch changes up to c2727e5004fe011d19156d728babdf968515b28d: Update ZFS support to latest (Thu Dec 7 16:09:26 2017 +0900) ---------------------------------------------------------------- Jorgen Lundman (1): Update ZFS support to latest cmd/zfs.c | 22 +- fs/zfs/Makefile | 4 +- fs/zfs/dev.c | 20 +- fs/zfs/zfs.c | 3223 +++++++++++++++++++++++++++++++----------- fs/zfs/zfs_fletcher.c | 6 +- fs/zfs/zfs_lz4.c | 286 ++++ fs/zfs/zfs_sha256.c | 14 +- include/zfs/dmu.h | 48 +- include/zfs/sa_impl.h | 5 +- include/zfs/spa.h | 18 + include/zfs/uberblock_impl.h | 15 +- include/zfs/zap_leaf.h | 4 +- include/zfs/zfs.h | 22 +- include/zfs/zio.h | 9 +- include/zfs_common.h | 27 +- 15 files changed, 2819 insertions(+), 904 deletions(-)