Patchwork [v2] NAND: DaVinci: Removed header file that is not required

login
register
mail settings
Submitter Sandeep Paulraj
Date March 7, 2011, 6:50 p.m.
Message ID <1299523844-14034-1-git-send-email-s-paulraj@ti.com>
Download mbox | patch
Permalink /patch/85790/
State New
Headers show

Comments

Sandeep Paulraj - March 7, 2011, 6:50 p.m.
From: Sandeep Paulraj <s-paulraj@ti.com>

The DaVinci NAND driver was including the mach-types.h header
file.
This prevented the DaVinci NAND driver from getting used
in a DSP only device. The linux port on c6x devices can make
use of the same driver and does not define a corresponding
header file.

This header file was required in the driver because earlier there was code
dependent on a machine_* check. This piece of code has now been factored out
and is in arch/arm/mach-davinci/aemif.c

Thus removing the header file is harmless

Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
---
Changes since V1
-better patch description based on Artem's comments

 drivers/mtd/nand/davinci_nand.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Artem Bityutskiy - March 8, 2011, 12:33 p.m.
On Mon, 2011-03-07 at 13:50 -0500, s-paulraj@ti.com wrote:
> From: Sandeep Paulraj <s-paulraj@ti.com>
> 
> The DaVinci NAND driver was including the mach-types.h header
> file.
> This prevented the DaVinci NAND driver from getting used
> in a DSP only device. The linux port on c6x devices can make
> use of the same driver and does not define a corresponding
> header file.
> 
> This header file was required in the driver because earlier there was code
> dependent on a machine_* check. This piece of code has now been factored out
> and is in arch/arm/mach-davinci/aemif.c
> 
> Thus removing the header file is harmless
> 
> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>

Pushed to l2-mtd-2.6.git, thanks!

Patch

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index a90fde3..aff3468 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -37,9 +37,6 @@ 
 #include <mach/nand.h>
 #include <mach/aemif.h>
 
-#include <asm/mach-types.h>
-
-
 /*
  * This is a device driver for the NAND flash controller found on the
  * various DaVinci family chips.  It handles up to four SoC chipselects,