| Message ID | 1515512687-16263-3-git-send-email-oe5hpm@oevsv.at |
|---|---|
| State | Superseded |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | am335x-fb: support display PLL for lcd-clock / pixel-clock | expand |
On Tue, Jan 09, 2018 at 04:44:43PM +0100, Hannes Schmelzer wrote: > Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at> > --- > > Changes in v2: None > > drivers/video/am335x-fb.c | 4 ++-- > drivers/video/am335x-fb.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c > index a8b3e74..8cdd2ec 100644 > --- a/drivers/video/am335x-fb.c > +++ b/drivers/video/am335x-fb.c > @@ -1,6 +1,6 @@ > /* > - * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> > - * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com > + * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> > + * B&R Industrial Automation GmbH - http://www.br-automation.com I am not a lawyer, but shouldn't you either be doing inclusive or 2013,2018, whichever the currently suggested (or company legal dept) way is? And then fold this into 4/6 where you're making real changes, please. Thanks!
mfG Schmelzer Hannes On 01/09/2018 05:04 PM, Tom Rini wrote: > On Tue, Jan 09, 2018 at 04:44:43PM +0100, Hannes Schmelzer wrote: >> Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at> >> --- >> >> Changes in v2: None >> >> drivers/video/am335x-fb.c | 4 ++-- >> drivers/video/am335x-fb.h | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c >> index a8b3e74..8cdd2ec 100644 >> --- a/drivers/video/am335x-fb.c >> +++ b/drivers/video/am335x-fb.c >> @@ -1,6 +1,6 @@ >> /* >> - * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> >> - * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com >> + * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> >> + * B&R Industrial Automation GmbH - http://www.br-automation.com > I am not a lawyer, but shouldn't you either be doing inclusive or > 2013,2018, whichever the currently suggested (or company legal dept) way > is? And then fold this into 4/6 where you're making real changes, > please. Thanks! > Hi Tom, thanks for input. I'm also not sure about this, since i'm not a lawyer too. But from the point of view, that the old company doesn't exist any more after the name change i think it shouldn't be a problem for doing so. If you're are also fine with this, i would suggest to take the patch as it is. cheers, Hannes
On Tue, Jan 09, 2018 at 06:35:04PM +0100, Hannes Schmelzer wrote: > > mfG > Schmelzer Hannes > > On 01/09/2018 05:04 PM, Tom Rini wrote: > >On Tue, Jan 09, 2018 at 04:44:43PM +0100, Hannes Schmelzer wrote: > >>Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at> > >>--- > >> > >>Changes in v2: None > >> > >> drivers/video/am335x-fb.c | 4 ++-- > >> drivers/video/am335x-fb.h | 4 ++-- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > >> > >>diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c > >>index a8b3e74..8cdd2ec 100644 > >>--- a/drivers/video/am335x-fb.c > >>+++ b/drivers/video/am335x-fb.c > >>@@ -1,6 +1,6 @@ > >> /* > >>- * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> > >>- * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com > >>+ * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> > >>+ * B&R Industrial Automation GmbH - http://www.br-automation.com > >I am not a lawyer, but shouldn't you either be doing inclusive or > >2013,2018, whichever the currently suggested (or company legal dept) way > >is? And then fold this into 4/6 where you're making real changes, > >please. Thanks! > > > Hi Tom, > thanks for input. I'm also not sure about this, since i'm not a lawyer too. > But from the point of view, that the old company doesn't exist any more > after the name change i think it shouldn't be a problem for doing so. > > If you're are also fine with this, i would suggest to take the patch as it > is. Ugh. If "Bernecker & Rainer Industrieelektronik GmbH" is now legally "B&R Industrial Automation GmbH", I would assume you can just extend the copyright years. Dropping 2013 and making it 2018 isn't the right way, that much I do know.
On 01/09/2018 06:39 PM, Tom Rini wrote: > On Tue, Jan 09, 2018 at 06:35:04PM +0100, Hannes Schmelzer wrote: >> mfG >> Schmelzer Hannes >> >> On 01/09/2018 05:04 PM, Tom Rini wrote: >>> On Tue, Jan 09, 2018 at 04:44:43PM +0100, Hannes Schmelzer wrote: >>>> Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at> >>>> --- >>>> >>>> Changes in v2: None >>>> >>>> drivers/video/am335x-fb.c | 4 ++-- >>>> drivers/video/am335x-fb.h | 4 ++-- >>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c >>>> index a8b3e74..8cdd2ec 100644 >>>> --- a/drivers/video/am335x-fb.c >>>> +++ b/drivers/video/am335x-fb.c >>>> @@ -1,6 +1,6 @@ >>>> /* >>>> - * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> >>>> - * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com >>>> + * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> >>>> + * B&R Industrial Automation GmbH - http://www.br-automation.com >>> I am not a lawyer, but shouldn't you either be doing inclusive or >>> 2013,2018, whichever the currently suggested (or company legal dept) way >>> is? And then fold this into 4/6 where you're making real changes, >>> please. Thanks! >>> >> Hi Tom, >> thanks for input. I'm also not sure about this, since i'm not a lawyer too. >> But from the point of view, that the old company doesn't exist any more >> after the name change i think it shouldn't be a problem for doing so. >> >> If you're are also fine with this, i would suggest to take the patch as it >> is. > Ugh. If "Bernecker & Rainer Industrieelektronik GmbH" is now legally > "B&R Industrial Automation GmbH", I would assume you can just extend the > copyright years. Dropping 2013 and making it 2018 isn't the right way, > that much I do know. Yeah, your'e right. So let it look like: + * Copyright (C) 2013-2018 Hannes Schmelzer <oe5hpm@oevsv.at> + * B&R Industrial Automation GmbH - http://www.br-automation.com I've to confess, that i haven't thought about that in that deep. cheers, Hannes
On Tue, Jan 09, 2018 at 06:51:28PM +0100, Hannes Schmelzer wrote: > On 01/09/2018 06:39 PM, Tom Rini wrote: > >On Tue, Jan 09, 2018 at 06:35:04PM +0100, Hannes Schmelzer wrote: > >>mfG > >>Schmelzer Hannes > >> > >>On 01/09/2018 05:04 PM, Tom Rini wrote: > >>>On Tue, Jan 09, 2018 at 04:44:43PM +0100, Hannes Schmelzer wrote: > >>>>Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at> > >>>>--- > >>>> > >>>>Changes in v2: None > >>>> > >>>> drivers/video/am335x-fb.c | 4 ++-- > >>>> drivers/video/am335x-fb.h | 4 ++-- > >>>> 2 files changed, 4 insertions(+), 4 deletions(-) > >>>> > >>>>diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c > >>>>index a8b3e74..8cdd2ec 100644 > >>>>--- a/drivers/video/am335x-fb.c > >>>>+++ b/drivers/video/am335x-fb.c > >>>>@@ -1,6 +1,6 @@ > >>>> /* > >>>>- * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> > >>>>- * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com > >>>>+ * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> > >>>>+ * B&R Industrial Automation GmbH - http://www.br-automation.com > >>>I am not a lawyer, but shouldn't you either be doing inclusive or > >>>2013,2018, whichever the currently suggested (or company legal dept) way > >>>is? And then fold this into 4/6 where you're making real changes, > >>>please. Thanks! > >>> > >>Hi Tom, > >>thanks for input. I'm also not sure about this, since i'm not a lawyer too. > >>But from the point of view, that the old company doesn't exist any more > >>after the name change i think it shouldn't be a problem for doing so. > >> > >>If you're are also fine with this, i would suggest to take the patch as it > >>is. > >Ugh. If "Bernecker & Rainer Industrieelektronik GmbH" is now legally > >"B&R Industrial Automation GmbH", I would assume you can just extend the > >copyright years. Dropping 2013 and making it 2018 isn't the right way, > >that much I do know. > Yeah, your'e right. So let it look like: > > + * Copyright (C) 2013-2018 Hannes Schmelzer <oe5hpm@oevsv.at> > + * B&R Industrial Automation GmbH - http://www.br-automation.com > > I've to confess, that i haven't thought about that in that deep. Works for me, thanks!
diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c index a8b3e74..8cdd2ec 100644 --- a/drivers/video/am335x-fb.c +++ b/drivers/video/am335x-fb.c @@ -1,6 +1,6 @@ /* - * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> - * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com + * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> + * B&R Industrial Automation GmbH - http://www.br-automation.com * * minimal framebuffer driver for TI's AM335x SoC to be compatible with * Wolfgang Denk's LCD-Framework (CONFIG_LCD, common/lcd.c) diff --git a/drivers/video/am335x-fb.h b/drivers/video/am335x-fb.h index 3f4b567..1980eda 100644 --- a/drivers/video/am335x-fb.h +++ b/drivers/video/am335x-fb.h @@ -1,6 +1,6 @@ /* - * Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at> - - * Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com + * Copyright (C) 2018 Hannes Schmelzer <oe5hpm@oevsv.at> - + * B&R Industrial Automation GmbH - http://www.br-automation.com * * SPDX-License-Identifier: GPL-2.0+ */
Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at> --- Changes in v2: None drivers/video/am335x-fb.c | 4 ++-- drivers/video/am335x-fb.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)