From patchwork Mon Mar 7 11:13:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 85728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4C289B7104 for ; Mon, 7 Mar 2011 22:13:46 +1100 (EST) Received: (qmail 6675 invoked by alias); 7 Mar 2011 11:13:44 -0000 Received: (qmail 6666 invoked by uid 22791); 7 Mar 2011 11:13:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 11:13:39 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 190FFC48; Mon, 7 Mar 2011 12:13:36 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XbDNOqrWbvwR; Mon, 7 Mar 2011 12:13:35 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 58C38C46; Mon, 7 Mar 2011 12:13:35 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p27BDY3t007165; Mon, 7 Mar 2011 12:13:34 +0100 (MET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Ian Lance Taylor Subject: [libgo] Don't check gopher, http ports Date: Mon, 07 Mar 2011 12:13:34 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The gopher (sort of understandable) and http (unexpected and strange) ports are missing form Solaris 2 /etc/services as far back as Solaris 8, which causes the libgo net test to fail: --- FAIL: net.TestLookupPort LookupPort("tcp", "gopher") = 0, unknown port tcp/gopher; want 70 LookupPort("tcp", "http") = 0, unknown port tcp/http; want 80 Since having those two ports above all the others adds no extra value, I've simply removed them to fix the test. Rainer 2011-03-05 Rainer Orth * go/net/port_test.go (porttests): Remove gopher, http. diff -r d7e61c7ee1b8 libgo/go/net/port_test.go --- a/libgo/go/net/port_test.go Sat Mar 05 23:39:02 2011 +0100 +++ b/libgo/go/net/port_test.go Sat Mar 05 23:46:42 2011 +0100 @@ -1,4 +1,4 @@ -// Copyright 2009 The Go Authors. All rights reserved. +// Copyright 2009, 2011 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. @@ -27,9 +27,7 @@ {"tcp", "smtp", 25, true}, {"tcp", "time", 37, true}, {"tcp", "domain", 53, true}, - {"tcp", "gopher", 70, true}, {"tcp", "finger", 79, true}, - {"tcp", "http", 80, true}, {"udp", "echo", 7, true}, {"udp", "tftp", 69, true},