Patchwork rbd: don't link with -lcrypto

login
register
mail settings
Submitter Aurelien Jarno
Date March 7, 2011, 6:17 a.m.
Message ID <1299478669-11231-1-git-send-email-aurelien@aurel32.net>
Download mbox | patch
Permalink /patch/85687/
State New
Headers show

Comments

Aurelien Jarno - March 7, 2011, 6:17 a.m.
rbd support tries to both link with -lrados and -lcrypto. While the
first one is of course necessary, the second is not necessary (only
librados ifself needs to link with libcrypto).

This fixes a licensing issue: qemu as a whole is GPL v2, and thus can't
be linked with OpenSSL without an exception in the license, which seems
Christian Brunner - March 13, 2011, 9:16 p.m.
You are right, libcrypto can be omitted.

(Recent versions of ceph use crypto++ anyway.)

Thanks, Christian


Reviewed-by: Christian Brunner <chb@muc.de>


2011/3/7 Aurelien Jarno <aurelien@aurel32.net>:
> rbd support tries to both link with -lrados and -lcrypto. While the
> first one is of course necessary, the second is not necessary (only
> librados ifself needs to link with libcrypto).
>
> This fixes a licensing issue: qemu as a whole is GPL v2, and thus can't
> be linked with OpenSSL without an exception in the license, which seems
> difficult to get given the number of persons involved.
>
> Cc: Christian Brunner <chb@muc.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index ef51a58..5932e39 100755
> --- a/configure
> +++ b/configure
> @@ -1801,7 +1801,7 @@ if test "$rbd" != "no" ; then
>  #include <rados/librados.h>
>  int main(void) { rados_initialize(0, NULL); return 0; }
>  EOF
> -  rbd_libs="-lrados -lcrypto"
> +  rbd_libs="-lrados"
>   if compile_prog "" "$rbd_libs" ; then
>     librados_too_old=no
>     cat > $TMPC <<EOF
> --
> 1.7.2.3
>
>
>

Patch

difficult to get given the number of persons involved.

Cc: Christian Brunner <chb@muc.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index ef51a58..5932e39 100755
--- a/configure
+++ b/configure
@@ -1801,7 +1801,7 @@  if test "$rbd" != "no" ; then
 #include <rados/librados.h>
 int main(void) { rados_initialize(0, NULL); return 0; }
 EOF
-  rbd_libs="-lrados -lcrypto"
+  rbd_libs="-lrados"
   if compile_prog "" "$rbd_libs" ; then
     librados_too_old=no
     cat > $TMPC <<EOF