[GIT,PULL] ARM64: Xilinx ZynqMP SoC patches for v4.16

Message ID 84cfd3d5-f0e7-23dc-0e33-430a1f2dbdb0@monstr.eu
State New
Headers show
Series
  • [GIT,PULL] ARM64: Xilinx ZynqMP SoC patches for v4.16
Related show

Pull-request

https://github.com/Xilinx/linux-xlnx.git tags/zynqmp-soc-for-4.16

Message

Michal Simek Jan. 8, 2018, 1:02 p.m.
Hi guys,

please consider to pull these 3 patches to your tree. I have discussed
it with Arnd that this could be probably fine even it is a little bit late.

Thanks,
Michal


The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:

  Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)

are available in the git repository at:

  https://github.com/Xilinx/linux-xlnx.git tags/zynqmp-soc-for-4.16

for you to fetch changes up to cee8113a295acfc4cd25728d7c3d44e6bc3bbff9:

  soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
(2018-01-08 13:42:47 +0100)

----------------------------------------------------------------
arm: Xilinx ZynqMP SoC patches for v4.16

- Create drivers/soc/xilinx folder structure
- Add ZynqMP vcu init driver

----------------------------------------------------------------
Dhaval Shah (2):
      dt-bindings: soc: xilinx: Add DT bindings to xlnx_vcu driver
      soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver

Michal Simek (1):
      soc: xilinx: Create folder structure for soc specific drivers

 Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu.txt |  31 ++++++++
 drivers/soc/Kconfig                                       |   1 +
 drivers/soc/Makefile                                      |   1 +
 drivers/soc/xilinx/Kconfig                                |  19 +++++
 drivers/soc/xilinx/Makefile                               |   2 +
 drivers/soc/xilinx/xlnx_vcu.c                             | 630
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 684 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu.txt
 create mode 100644 drivers/soc/xilinx/Kconfig
 create mode 100644 drivers/soc/xilinx/Makefile
 create mode 100644 drivers/soc/xilinx/xlnx_vcu.c

Comments

Olof Johansson Jan. 12, 2018, 1:28 a.m. | #1
On Mon, Jan 08, 2018 at 02:02:18PM +0100, Michal Simek wrote:
> Hi guys,
> 
> please consider to pull these 3 patches to your tree. I have discussed
> it with Arnd that this could be probably fine even it is a little bit late.
> 
> Thanks,
> Michal
> 
> 
> The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:
> 
>   Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)
> 
> are available in the git repository at:
> 
>   https://github.com/Xilinx/linux-xlnx.git tags/zynqmp-soc-for-4.16
> 
> for you to fetch changes up to cee8113a295acfc4cd25728d7c3d44e6bc3bbff9:
> 
>   soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
> (2018-01-08 13:42:47 +0100)
> 
> ----------------------------------------------------------------
> arm: Xilinx ZynqMP SoC patches for v4.16
> 
> - Create drivers/soc/xilinx folder structure
> - Add ZynqMP vcu init driver
> 
> ----------------------------------------------------------------
> Dhaval Shah (2):
>       dt-bindings: soc: xilinx: Add DT bindings to xlnx_vcu driver
>       soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
> 
> Michal Simek (1):
>       soc: xilinx: Create folder structure for soc specific drivers
> 

Merged, but you should probably add a platform config option for Xilinx
and use that instead of obj-y to descend into the directory?


-Olof
Michal Simek Jan. 12, 2018, 6:44 a.m. | #2
On 12.1.2018 02:28, Olof Johansson wrote:
> On Mon, Jan 08, 2018 at 02:02:18PM +0100, Michal Simek wrote:
>> Hi guys,
>>
>> please consider to pull these 3 patches to your tree. I have discussed
>> it with Arnd that this could be probably fine even it is a little bit late.
>>
>> Thanks,
>> Michal
>>
>>
>> The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:
>>
>>   Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)
>>
>> are available in the git repository at:
>>
>>   https://github.com/Xilinx/linux-xlnx.git tags/zynqmp-soc-for-4.16
>>
>> for you to fetch changes up to cee8113a295acfc4cd25728d7c3d44e6bc3bbff9:
>>
>>   soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
>> (2018-01-08 13:42:47 +0100)
>>
>> ----------------------------------------------------------------
>> arm: Xilinx ZynqMP SoC patches for v4.16
>>
>> - Create drivers/soc/xilinx folder structure
>> - Add ZynqMP vcu init driver
>>
>> ----------------------------------------------------------------
>> Dhaval Shah (2):
>>       dt-bindings: soc: xilinx: Add DT bindings to xlnx_vcu driver
>>       soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
>>
>> Michal Simek (1):
>>       soc: xilinx: Create folder structure for soc specific drivers
>>
> 
> Merged, but you should probably add a platform config option for Xilinx
> and use that instead of obj-y to descend into the directory?

Do you think change like this?

-obj-y                          += xilinx/
+obj-$(CONFIG_ARCH_ZYNQMP)      += xilinx/

Just a note. This folder is supposed to be used by arm64/arm32 and
microblaze that's why I didn't put there any single config because it
doesn't exist. If you suggest to introduce new config option to label
xilinx platforms we can talk about it.
Argument against it could be also using these drivers by openrisc or
mips (mipsfpga) which are also fpga based.
Anyway I am happy to hear what you suggest.

Thanks,
Michal
Arnd Bergmann Jan. 12, 2018, 8:44 a.m. | #3
On Fri, Jan 12, 2018 at 7:44 AM, Michal Simek <monstr@monstr.eu> wrote:
> On 12.1.2018 02:28, Olof Johansson wrote:
>> On Mon, Jan 08, 2018 at 02:02:18PM +0100, Michal Simek wrote:

>>> ----------------------------------------------------------------
>>> Dhaval Shah (2):
>>>       dt-bindings: soc: xilinx: Add DT bindings to xlnx_vcu driver
>>>       soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
>>>
>>> Michal Simek (1):
>>>       soc: xilinx: Create folder structure for soc specific drivers
>>>
>>
>> Merged, but you should probably add a platform config option for Xilinx
>> and use that instead of obj-y to descend into the directory?

I don't see it in arm-soc yet, did you forget to push the latest branches?

> Do you think change like this?
>
> -obj-y                          += xilinx/
> +obj-$(CONFIG_ARCH_ZYNQMP)      += xilinx/
>
> Just a note. This folder is supposed to be used by arm64/arm32 and
> microblaze that's why I didn't put there any single config because it
> doesn't exist. If you suggest to introduce new config option to label
> xilinx platforms we can talk about it.
> Argument against it could be also using these drivers by openrisc or
> mips (mipsfpga) which are also fpga based.
> Anyway I am happy to hear what you suggest.
>

I think obj-y is fine in this case, the cost is minimal.

      Arnd
Olof Johansson Jan. 12, 2018, 6:18 p.m. | #4
On Fri, Jan 12, 2018 at 12:44 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Jan 12, 2018 at 7:44 AM, Michal Simek <monstr@monstr.eu> wrote:
>> On 12.1.2018 02:28, Olof Johansson wrote:
>>> On Mon, Jan 08, 2018 at 02:02:18PM +0100, Michal Simek wrote:
>
>>>> ----------------------------------------------------------------
>>>> Dhaval Shah (2):
>>>>       dt-bindings: soc: xilinx: Add DT bindings to xlnx_vcu driver
>>>>       soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver
>>>>
>>>> Michal Simek (1):
>>>>       soc: xilinx: Create folder structure for soc specific drivers
>>>>
>>>
>>> Merged, but you should probably add a platform config option for Xilinx
>>> and use that instead of obj-y to descend into the directory?
>
> I don't see it in arm-soc yet, did you forget to push the latest branches?

Hm, not sure what happened there. Fixing now.

>
>> Do you think change like this?
>>
>> -obj-y                          += xilinx/
>> +obj-$(CONFIG_ARCH_ZYNQMP)      += xilinx/
>>
>> Just a note. This folder is supposed to be used by arm64/arm32 and
>> microblaze that's why I didn't put there any single config because it
>> doesn't exist. If you suggest to introduce new config option to label
>> xilinx platforms we can talk about it.
>> Argument against it could be also using these drivers by openrisc or
>> mips (mipsfpga) which are also fpga based.
>> Anyway I am happy to hear what you suggest.
>>
>
> I think obj-y is fine in this case, the cost is minimal.

Yeah, if it's across platforms/architectures like this it's fine.


-Olof