| Message ID | 20180106181802.9298-3-jarush@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | spi: cadence_spi: Adopt Linux DT bindings | expand |
On Sat, Jan 6, 2018 at 11:47 PM, Jason Rush <jarush@gmail.com> wrote: > Adopt the Linux DT bindings and clean-up duplicate > and unused values. > > Tested on TI K2G platform: > Tested-by: Vignesh R <vigneshr@ti.com> > > Tested on a socfpga-cyclonev board: > Tested-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com> > > Signed-off-by: Jason Rush <jarush@gmail.com> > Cc: Marek Vasut <marex@denx.de> > --- checkpatch errors/warnings?
On 1/23/2018 3:16 AM, Jagan Teki wrote: > On Sat, Jan 6, 2018 at 11:47 PM, Jason Rush <jarush@gmail.com> wrote: >> Adopt the Linux DT bindings and clean-up duplicate >> and unused values. >> >> Tested on TI K2G platform: >> Tested-by: Vignesh R <vigneshr@ti.com> >> >> Tested on a socfpga-cyclonev board: >> Tested-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com> >> >> Signed-off-by: Jason Rush <jarush@gmail.com> >> Cc: Marek Vasut <marex@denx.de> >> --- > checkpatch errors/warnings? checkpatch complains about using spaces for indentation in the arch/arm/dts/keystone-k2g-evm.dts file. The entire flash node was originally indented using spaces in this file before this patch, so I kept the indentation as it was originally when I updated this file in patch (2/5). I then fixed all the indentation in this file in commit 4/5 in this series. Is this okay? -- Jason
On Tue, Jan 23, 2018 at 7:45 PM, Jason Rush <jarush@gmail.com> wrote: > On 1/23/2018 3:16 AM, Jagan Teki wrote: >> On Sat, Jan 6, 2018 at 11:47 PM, Jason Rush <jarush@gmail.com> wrote: >>> Adopt the Linux DT bindings and clean-up duplicate >>> and unused values. >>> >>> Tested on TI K2G platform: >>> Tested-by: Vignesh R <vigneshr@ti.com> >>> >>> Tested on a socfpga-cyclonev board: >>> Tested-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com> >>> >>> Signed-off-by: Jason Rush <jarush@gmail.com> >>> Cc: Marek Vasut <marex@denx.de> >>> --- >> checkpatch errors/warnings? > > checkpatch complains about using spaces for indentation in the > arch/arm/dts/keystone-k2g-evm.dts file. The entire flash node > was originally indented using spaces in this file before this patch, > so I kept the indentation as it was originally when I updated this > file in patch (2/5). I then fixed all the indentation in this file in > commit 4/5 in this series. Is this okay? Better to squash and update commit message.
On 1/23/2018 8:25 AM, Jagan Teki wrote: > On Tue, Jan 23, 2018 at 7:45 PM, Jason Rush <jarush@gmail.com> wrote: >> On 1/23/2018 3:16 AM, Jagan Teki wrote: >>> On Sat, Jan 6, 2018 at 11:47 PM, Jason Rush <jarush@gmail.com> wrote: >>>> Adopt the Linux DT bindings and clean-up duplicate >>>> and unused values. >>>> >>>> Tested on TI K2G platform: >>>> Tested-by: Vignesh R <vigneshr@ti.com> >>>> >>>> Tested on a socfpga-cyclonev board: >>>> Tested-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com> >>>> >>>> Signed-off-by: Jason Rush <jarush@gmail.com> >>>> Cc: Marek Vasut <marex@denx.de> >>>> --- >>> checkpatch errors/warnings? >> checkpatch complains about using spaces for indentation in the >> arch/arm/dts/keystone-k2g-evm.dts file. The entire flash node >> was originally indented using spaces in this file before this patch, >> so I kept the indentation as it was originally when I updated this >> file in patch (2/5). I then fixed all the indentation in this file in >> commit 4/5 in this series. Is this okay? > Better to squash and update commit message. Will do. Do you want me to add your reviewed-by tag to the commit messages?
On Tue, Jan 23, 2018 at 8:42 PM, Jason Rush <jarush@gmail.com> wrote: > On 1/23/2018 8:25 AM, Jagan Teki wrote: >> On Tue, Jan 23, 2018 at 7:45 PM, Jason Rush <jarush@gmail.com> wrote: >>> On 1/23/2018 3:16 AM, Jagan Teki wrote: >>>> On Sat, Jan 6, 2018 at 11:47 PM, Jason Rush <jarush@gmail.com> wrote: >>>>> Adopt the Linux DT bindings and clean-up duplicate >>>>> and unused values. >>>>> >>>>> Tested on TI K2G platform: >>>>> Tested-by: Vignesh R <vigneshr@ti.com> >>>>> >>>>> Tested on a socfpga-cyclonev board: >>>>> Tested-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com> >>>>> >>>>> Signed-off-by: Jason Rush <jarush@gmail.com> >>>>> Cc: Marek Vasut <marex@denx.de> >>>>> --- >>>> checkpatch errors/warnings? >>> checkpatch complains about using spaces for indentation in the >>> arch/arm/dts/keystone-k2g-evm.dts file. The entire flash node >>> was originally indented using spaces in this file before this patch, >>> so I kept the indentation as it was originally when I updated this >>> file in patch (2/5). I then fixed all the indentation in this file in >>> commit 4/5 in this series. Is this okay? >> Better to squash and update commit message. > > Will do. Do you want me to add your reviewed-by tag to the > commit messages? yes along with tags from cover-letter patch because patchwork didn't pick those.
diff --git a/arch/arm/dts/keystone-k2g-evm.dts b/arch/arm/dts/keystone-k2g-evm.dts index de208b3613..ba566a4328 100644 --- a/arch/arm/dts/keystone-k2g-evm.dts +++ b/arch/arm/dts/keystone-k2g-evm.dts @@ -76,10 +76,10 @@ spi-max-frequency = <96000000>; #address-cells = <1>; #size-cells = <1>; - tshsl-ns = <392>; - tsd2d-ns = <392>; - tchsh-ns = <100>; - tslch-ns = <100>; + cdns,tshsl-ns = <392>; + cdns,tsd2d-ns = <392>; + cdns,tchsh-ns = <100>; + cdns,tslch-ns = <100>; block-size = <18>; diff --git a/arch/arm/dts/keystone-k2g.dtsi b/arch/arm/dts/keystone-k2g.dtsi index 7b2fae6860..9bcfea6d86 100644 --- a/arch/arm/dts/keystone-k2g.dtsi +++ b/arch/arm/dts/keystone-k2g.dtsi @@ -92,8 +92,9 @@ <0x24000000 0x4000000>; interrupts = <GIC_SPI 198 IRQ_TYPE_EDGE_RISING>; num-cs = <4>; - fifo-depth = <256>; - sram-size = <256>; + cdns,fifo-depth = <256>; + cdns,fifo-width = <4>; + cdns,trigger-address = <0x24000000>; status = "disabled"; }; diff --git a/arch/arm/dts/socfpga.dtsi b/arch/arm/dts/socfpga.dtsi index 8588221e57..7557aa01e5 100644 --- a/arch/arm/dts/socfpga.dtsi +++ b/arch/arm/dts/socfpga.dtsi @@ -644,8 +644,9 @@ clocks = <&qspi_clk>; ext-decoder = <0>; /* external decoder */ num-cs = <4>; - fifo-depth = <128>; - sram-size = <128>; + cdns,fifo-depth = <128>; + cdns,fifo-width = <4>; + cdns,trigger-address = <0x00000000>; bus-num = <2>; status = "disabled"; }; diff --git a/arch/arm/dts/socfpga_arria10.dtsi b/arch/arm/dts/socfpga_arria10.dtsi index 377700df11..abfd0bc4f8 100644 --- a/arch/arm/dts/socfpga_arria10.dtsi +++ b/arch/arm/dts/socfpga_arria10.dtsi @@ -734,8 +734,8 @@ clocks = <&l4_main_clk>; ext-decoder = <0>; /* external decoder */ num-chipselect = <4>; - fifo-depth = <128>; - sram-size = <512>; + cdns,fifo-depth = <128>; + cdns,fifo-width = <4>; bus-num = <2>; status = "disabled"; }; diff --git a/arch/arm/dts/socfpga_arria5_socdk.dts b/arch/arm/dts/socfpga_arria5_socdk.dts index 726505821f..1e91a65af6 100644 --- a/arch/arm/dts/socfpga_arria5_socdk.dts +++ b/arch/arm/dts/socfpga_arria5_socdk.dts @@ -94,10 +94,9 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/socfpga_cyclone5_is1.dts b/arch/arm/dts/socfpga_cyclone5_is1.dts index 16a3283710..2e2b71fefb 100644 --- a/arch/arm/dts/socfpga_cyclone5_is1.dts +++ b/arch/arm/dts/socfpga_cyclone5_is1.dts @@ -93,11 +93,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/socfpga_cyclone5_socdk.dts b/arch/arm/dts/socfpga_cyclone5_socdk.dts index f175ef2ead..95a8e653d7 100644 --- a/arch/arm/dts/socfpga_cyclone5_socdk.dts +++ b/arch/arm/dts/socfpga_cyclone5_socdk.dts @@ -104,11 +104,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/socfpga_cyclone5_sockit.dts b/arch/arm/dts/socfpga_cyclone5_sockit.dts index e45c2abbc2..6f42b88130 100644 --- a/arch/arm/dts/socfpga_cyclone5_sockit.dts +++ b/arch/arm/dts/socfpga_cyclone5_sockit.dts @@ -84,11 +84,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/socfpga_cyclone5_socrates.dts b/arch/arm/dts/socfpga_cyclone5_socrates.dts index bdd93248fb..e3ae8a8207 100644 --- a/arch/arm/dts/socfpga_cyclone5_socrates.dts +++ b/arch/arm/dts/socfpga_cyclone5_socrates.dts @@ -74,11 +74,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/socfpga_cyclone5_sr1500.dts b/arch/arm/dts/socfpga_cyclone5_sr1500.dts index 739bbb7f3d..e24830af57 100644 --- a/arch/arm/dts/socfpga_cyclone5_sr1500.dts +++ b/arch/arm/dts/socfpga_cyclone5_sr1500.dts @@ -92,10 +92,9 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts index f168e4ff99..a0febe91b0 100644 --- a/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts +++ b/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts @@ -79,11 +79,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; flash1: n25q00@1 { @@ -96,11 +95,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - read-delay = <4>; /* delay value in read data capture register */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts index fa3fd641b2..bceac09154 100644 --- a/arch/arm/dts/stv0991.dts +++ b/arch/arm/dts/stv0991.dts @@ -32,7 +32,9 @@ reg = <0x80203000 0x100>, <0x40000000 0x1000000>; clocks = <3750000>; - sram-size = <256>; + cdns,fifo-depth = <256>; + cdns,fifo-width = <4>; + cdns,trigger-address = <0x40000000>; status = "okay"; flash0: n25q32@0 { @@ -44,10 +46,10 @@ m25p,fast-read; page-size = <256>; block-size = <16>; /* 2^16, 64KB */ - tshsl-ns = <50>; - tsd2d-ns = <50>; - tchsh-ns = <4>; - tslch-ns = <4>; + cdns,tshsl-ns = <50>; + cdns,tsd2d-ns = <50>; + cdns,tchsh-ns = <4>; + cdns,tslch-ns = <4>; }; }; };