pinctrl: remove redundant mux_setting clear in pinmux_disable_setting()

Message ID 1515149546-31282-1-git-send-email-yamada.masahiro@socionext.com
State New
Headers show
Series
  • pinctrl: remove redundant mux_setting clear in pinmux_disable_setting()
Related show

Commit Message

Masahiro Yamada Jan. 5, 2018, 10:52 a.m.
desc->mux_setting is set to NULL in pin_free() called just below.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/pinctrl/pinmux.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Linus Walleij Jan. 9, 2018, 1:49 p.m. | #1
On Fri, Jan 5, 2018 at 11:52 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> desc->mux_setting is set to NULL in pin_free() called just below.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied.

Excellent work, as always.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 55502fc..82b18ef 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -493,8 +493,6 @@  void pinmux_disable_setting(const struct pinctrl_setting *setting)
 			continue;
 		}
 		if (desc->mux_setting == &(setting->data.mux)) {
-			desc->mux_setting = NULL;
-			/* And release the pin */
 			pin_free(pctldev, pins[i], NULL);
 		} else {
 			const char *gname;