diff mbox series

[v3,06/18] tests/docker: add test-debug

Message ID 20180104160523.22995-7-marcandre.lureau@redhat.com
State New
Headers show
Series Various build-sys and sanitizer related fixes | expand

Commit Message

Marc-André Lureau Jan. 4, 2018, 4:05 p.m. UTC
Add a new test with --enable-debug using clang/asan/ubsan, remove
--enable-debug from test-clang & test-mingw.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/docker/test-clang |  2 +-
 tests/docker/test-debug | 26 ++++++++++++++++++++++++++
 tests/docker/test-mingw |  2 --
 3 files changed, 27 insertions(+), 3 deletions(-)
 create mode 100755 tests/docker/test-debug

Comments

Philippe Mathieu-Daudé Jan. 4, 2018, 5:16 p.m. UTC | #1
On 01/04/2018 01:05 PM, Marc-André Lureau wrote:
> Add a new test with --enable-debug using clang/asan/ubsan, remove
> --enable-debug from test-clang & test-mingw.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/docker/test-clang |  2 +-
>  tests/docker/test-debug | 26 ++++++++++++++++++++++++++
>  tests/docker/test-mingw |  2 --
>  3 files changed, 27 insertions(+), 3 deletions(-)
>  create mode 100755 tests/docker/test-debug
> 
> diff --git a/tests/docker/test-clang b/tests/docker/test-clang
> index 1eb61a3af7..e90a793178 100755
> --- a/tests/docker/test-clang
> +++ b/tests/docker/test-clang
> @@ -17,7 +17,7 @@ requires clang
>  
>  cd "$BUILD_DIR"
>  
> -OPTS="--enable-debug --cxx=clang++ --cc=clang --host-cc=clang"
> +OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
>  # -fsanitize=undefined is broken on Fedora 23, skip it for now
>  # See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
>  #OPTS="$OPTS --extra-cflags=-fsanitize=undefined \


> diff --git a/tests/docker/test-debug b/tests/docker/test-debug
> new file mode 100755
> index 0000000000..d020b06917
> --- /dev/null
> +++ b/tests/docker/test-debug
> @@ -0,0 +1,26 @@
> +#!/bin/bash -e
> +#
> +# Compile and check with clang & --enable-debug.
> +#
> +# Copyright (c) 2016-2018 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <famz@redhat.com>
> +#  Marc-André Lureau <marcandre.lureau@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +. common.rc
> +
> +requires clang asan
> +
> +cd "$BUILD_DIR"
> +
> +OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
> +OPTS="--enable-debug $OPTS"
> +
> +build_qemu $OPTS
> +make $MAKEFLAGS check
> +install_qemu


> diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
> index 39a1da448e..503a6bc6f7 100755
> --- a/tests/docker/test-mingw
> +++ b/tests/docker/test-mingw
> @@ -22,7 +22,6 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
>      TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
>          build_qemu --cross-prefix=$prefix \
>          --enable-trace-backends=simple \
> -        --enable-debug \
>          --enable-gnutls \
>          --enable-nettle \
>          --enable-curl \
> @@ -35,4 +34,3 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
>      make clean
>  
>  done
> -
> 

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff mbox series

Patch

diff --git a/tests/docker/test-clang b/tests/docker/test-clang
index 1eb61a3af7..e90a793178 100755
--- a/tests/docker/test-clang
+++ b/tests/docker/test-clang
@@ -17,7 +17,7 @@  requires clang
 
 cd "$BUILD_DIR"
 
-OPTS="--enable-debug --cxx=clang++ --cc=clang --host-cc=clang"
+OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
 # -fsanitize=undefined is broken on Fedora 23, skip it for now
 # See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
 #OPTS="$OPTS --extra-cflags=-fsanitize=undefined \
diff --git a/tests/docker/test-debug b/tests/docker/test-debug
new file mode 100755
index 0000000000..d020b06917
--- /dev/null
+++ b/tests/docker/test-debug
@@ -0,0 +1,26 @@ 
+#!/bin/bash -e
+#
+# Compile and check with clang & --enable-debug.
+#
+# Copyright (c) 2016-2018 Red Hat Inc.
+#
+# Authors:
+#  Fam Zheng <famz@redhat.com>
+#  Marc-André Lureau <marcandre.lureau@redhat.com>
+#
+# This work is licensed under the terms of the GNU GPL, version 2
+# or (at your option) any later version. See the COPYING file in
+# the top-level directory.
+
+. common.rc
+
+requires clang asan
+
+cd "$BUILD_DIR"
+
+OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
+OPTS="--enable-debug $OPTS"
+
+build_qemu $OPTS
+make $MAKEFLAGS check
+install_qemu
diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
index 39a1da448e..503a6bc6f7 100755
--- a/tests/docker/test-mingw
+++ b/tests/docker/test-mingw
@@ -22,7 +22,6 @@  for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
     TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
         build_qemu --cross-prefix=$prefix \
         --enable-trace-backends=simple \
-        --enable-debug \
         --enable-gnutls \
         --enable-nettle \
         --enable-curl \
@@ -35,4 +34,3 @@  for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
     make clean
 
 done
-