Message ID | 1515032129-7899-3-git-send-email-fugang.duan@nxp.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zBs1w3q0Vz9s7n for <patchwork-incoming@ozlabs.org>; Thu, 4 Jan 2018 13:19:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbeADCTa (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Wed, 3 Jan 2018 21:19:30 -0500 Received: from mail-bn3nam01on0073.outbound.protection.outlook.com ([104.47.33.73]:21105 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751975AbeADCTY (ORCPT <rfc822;netdev@vger.kernel.org>); Wed, 3 Jan 2018 21:19:24 -0500 Received: from MWHPR03CA0053.namprd03.prod.outlook.com (10.174.173.170) by CY1PR03MB2361.namprd03.prod.outlook.com (10.166.207.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Thu, 4 Jan 2018 02:19:23 +0000 Received: from BY2FFO11OLC010.protection.gbl (2a01:111:f400:7c0c::138) by MWHPR03CA0053.outlook.office365.com (2603:10b6:301:3b::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Thu, 4 Jan 2018 02:19:22 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC010.mail.protection.outlook.com (10.1.15.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Thu, 4 Jan 2018 02:18:56 +0000 Received: from b54642-OptiPlex-3020.ap.freescale.net (b54642-OptiPlex-3020.ap.freescale.net [10.192.242.250]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w042JC8t025126; Wed, 3 Jan 2018 19:19:19 -0700 From: Fugang Duan <fugang.duan@nxp.com> To: <festevam@gmail.com>, <davem@davemloft.net> CC: <netdev@vger.kernel.org>, <troy.kisky@boundarydevices.com>, <andrew@lunn.ch>, <fugang.duan@nxp.com> Subject: [PATCH v3 net, stable 2/2] net: fec: defer probe if regulator is not ready Date: Thu, 4 Jan 2018 10:15:29 +0800 Message-ID: <1515032129-7899-3-git-send-email-fugang.duan@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1515032129-7899-1-git-send-email-fugang.duan@nxp.com> References: <1515032129-7899-1-git-send-email-fugang.duan@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131595059369009875; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(7966004)(346002)(39860400002)(396003)(39380400002)(376002)(2980300002)(1109001)(1110001)(339900001)(189003)(199004)(47776003)(85426001)(104016004)(53936002)(356003)(8676002)(81166006)(81156014)(8656006)(36756003)(39060400002)(110136005)(50226002)(8936002)(16586007)(54906003)(316002)(2906002)(305945005)(68736007)(50466002)(51416003)(77096006)(48376002)(76176011)(2950100002)(106466001)(6666003)(498600001)(5660300001)(105606002)(4326008)(97736004)(86362001)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2361; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC010; 1:LCr8heWKFpEFcwA4SXg7/7VF0sd5wBgadq7mWnTZdNii5JxqTNOIyp4hmEldH69TdQlB05uflABPB1m76lX5E2dgFfCH525YZN4loL9hVUkYjMTr2NWk5noQJ8Hr+urC MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d84868dc-f683-4b63-e2d3-08d553198259 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:CY1PR03MB2361; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 3:ORmnrwKK7UjTpMcy2lUkcKTQi5CbfU8KrVbOuoo34fqTeMQ3zF8/daY5/e6DwVPQm38ruPnBrS2XciuMFnWvYAeQzBnTtoMUqncpsauArHzc8Yw9hIubiBceg/ZSzWhX25vLDsFgmC16yeVPLYzYJSDzotlhxZ0Y/L52U7kK3IA6s62Sh/pGyxLcB7HcOWjxAOjGG+fyrm7Jsm2sqccufVCo/e4Tw2z3ySoFzQLY2HhQ2Xz3wt0W+UKzWY6dkC6TZc1XfuDExSDAfZ1AhliuedkCoePnETTX5e9RseT2jMhI8pTDDllkGyyy7nWXdD4TvtlFnRGKFo/otWR1iTiDUVxwakpkx/JwrtQ8ZE2aTBo=; 25:fMlBCH6YX7//bl+ctfpATkayXcOnG3GOJH1kteCWviCk04Ef9t31JKocwOpBZOWwje/xIAv0IRHq7epM4KdRr5esFWThVDC4deYJLB2ZJqiBuW3cjspaxksfymZT1MU+eXGN+OYV0EZam47GAVUgdnkX6KrhCUvOf42mX2sXnm/JbxYUBNGT9roRZUBw0s87GNsJChlV6743BXWGLWPDFByP6+g4hqeJF2kI4D3oyKCjCGhp4BeIrB/gqP2j6MSoxPZkjJ5zbi4CGuxJpnvUWFfYuou0tysrNh/6mGX/2LJhcC4GeF/yLuUZOU4TM6F1WTzsKT2sjJiJTjhaiUAcxQ== X-MS-TrafficTypeDiagnostic: CY1PR03MB2361: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 31:H9rshYMkLEHgaUBCX/fXxGHiAJk3KuFd5m440y6i2TDZWknYz3wMD/ezk8DAvbWI2IBNljo2/mcsdsfgH6PS0LULCGQluuwsqVqiqgcg0ZzPc0fIp7rFxRzvNXkmKu4/6V1lS7BKkIZbC5Us2envSAskaQVWutT9pLyAHAu0gy/j6w71VHcRVTdTEyx81DzBLeGNTgcigBgs+6jjoP6oPWHEaNsCeIDlSXVj5x0H+Js=; 4:/1wB3VO0RdA+GDBiWk8q/43OMIinaYkEbVESDLlogqIdggFPJ+bppqxsPd7Ku2YGApgh1X4RRlUziFoy28+Nmqm5rU1JQAFzEkSZT2Fu+EmPWG2je2mE83Uivs+aQL38O3Q4WSCVaGIVcmR7okWCevrtf3QoiHvb0NOOrxuDyMIKUd1Xup0Hztm9KAlC9nProCQxpbB/O0+n4wudSTYczrwk8sQenNwBcAsGp73dINiclX1oIYMs8KmNQTklVOFTyNzHQ3ae+kaC2a2+ceACh2IXNR1/9i4sWm9Q61BF9B9e6AGMI9v67AitLowvZZOE X-Microsoft-Antispam-PRVS: <CY1PR03MB2361E93BAC36918BC9EA217FFF1F0@CY1PR03MB2361.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(3002001)(3231023)(944510075)(944921075)(946801075)(946901075)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123559100)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025)(20161123561025)(20161123556025)(20161123563025)(201708071742011); SRVR:CY1PR03MB2361; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY1PR03MB2361; X-Forefront-PRVS: 054231DC40 X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 23:p//WGarbQWZggNuPR3SmEYSJQHgUG6MaHDO66IRVpqJ29m3KqotCfSKNVvAYbTZ9/1sU7UN0BOhB+OUoW9c/vNi3OESaJ8U28a5tUgnsX8+MPSZbuStKVpgEwQCBQKCb1YtilBm1v0cLhSWLn+qeCO9KPc4myTuvZPhp8U+nZf61jfuK91boHHHCmpwshnk/KsInN94bn2fkl2PQxDQG3Qd/Jn89t9p87OSePm/drmmUoVmXf8qh6wUSTAxKI+eiqeQ5avttuIevc+/Mi6BozVU/BuBJa/Sr1eWCt4xXD3xkSqrqtkofm6528vL+S0EyFuUazLiQJhG7Cxs7Lxb96rkwgo9eetK3iLsrdQExCnBTm0kKbLH4K/uOgQzf+sicNiaCcJBiKtI7U/UNlulqnZgYVCn0o3P9M8N4DQQ3HTCOiWg0DgbJgXxmVYL3ptWA6lE0/wgyEC4lpMh5OaNj2FPzJqcj1jgWR0FRs9+26Z3gBOH9nI2Do3jVp+uH5bvLpMJPnl2Nx9XWOl2Hj1JyZts9X8ZrkkIbOI3YMvXmrGY0FBB/we1mQM6bwke7sGFTgRA3zOR+zrH05VuYxHmmPS3f/borJnUK6otquDI1X4x22vvCQU1FuhhkoZKRugmB9Aux6EasAgICDQwMzvaxrXQF1l4lS+3n0QMeFWyhjkYKAa8u6V9b2KbCAZjoIU7Yi02MKmt5+PM+sqZWusU6lq5xYQ7XJBpjNZfT0hEjo4CTYsFNoE/id8gV8o5rDcTEv7caPwZuGpEFtKRWO7TAV72p6KubMcdeCsCWpJGIXI1ZZuHWp5TMW4z9fREte6PoAc0XOwR7rULVCObmUADiT3iRgalgWLF2CXafyCGrggrMG5S3ovn1gv/pTtwzGNqUg1mtoQAnY3wSaZX8OIujEbj7IS+6gxMVc4obeMdz6vGgDx/Oc6XsF8MW7cT+HJKQdI0VPSFWUDzK1h9WTwWAWKpP5ofVsCIXwfdylZ+pbfv6KIC05jC1eEP2qIyRKNLVdHl7iSX1poFpn5HezbBFcwQfprvuzgX/uUA6IAmLE/Lf1hRRE8Vtprr2rBTJPz3j7UZdE8LGSnIA8Uj3HHFsXcN0F8iL+9EEXfAIWl6AoGa2A4qbx2d0grdkMTKoijsE X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 6:68nEHTdSwtzZvf5WcbsCDpY87TJiEPzlTVmHPj/22D3dhBlIIMqx3La+YLFj4+3sLzYpOrU/o8dGN76SF82m56hsiszWAfIhvuVov5LOSkLW+hlErYivPDMBDr8WjLGO5b9k/C/0C462Q1hG6Nlic87rcSAJfgUnV/XrkHkQC1ZdFlGndxwICsdxmR1Whn/OGOwQVuWJVqXPje13Os7GTCK6Yp/wuotD/T0LDwK/8TTA99HjXy5OnAv82bQKoLHQid+DhZ1KjFisjuUINDHBYGTo+TCmV5hT/Hi9T40x6GAP+FUzaF5gMVlyFs5VSDq82JncoWIg3EhAhm7HdjLyBc1nI8kYeAYyMvBoQCYHoPc=; 5:5kxDYJGdalb1Jl2n+/+hXnMVKByk/QmAV+5rcTGFx2NiP28x1XKXHXA+RVFAY2ogDET+SkjwikeoOoj7KMtmR9C8SbTKASLGzXvIv2saed5V/oIBPtdJZKEQNME8EUL1Yqu+zYFXpu+WZkstDKvXCIxniwpnSyWj9qkivJhHG+E=; 24:reejkPWpE4oHbX4F7M+kTVvucxmj3AoylnNOV4UJJwcBDXInkBxoJUCwMXGCMFiU6OKvihzDhK9VFZqsW/4t6BgbSAM7TP9ZOEtMUkHaNoU=; 7:WE8l2HuAaySHghMcZW3E/6OwQ0YcfmWomfy0fNVJ8Q7aboXYQjXiOY2kQfYc9jur99gDuBJv+zp0Yj33FMG3pQ4vTUdJbxoIbQKtdnRaSmDEKDvj6CH+zRNdgejP2kvwS9FlZvW0oR/x8oXrNwekfCl2TrdG7YWUkuWbu1nJkq7h/Em5B6KbjVommluKiYTQNr0vIoh9hez3q0aX0zt98XbnrzFSGlwSMLd4nzX8gdyKNE/fnWlwtN2R1v2r+xEl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2018 02:18:56.6982 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d84868dc-f683-4b63-e2d3-08d553198259 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2361 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
net: fec: clean up in the cases of probe error
|
expand
|
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 732a8e3..a32fbf5 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3489,6 +3489,10 @@ static int fec_enet_get_irq_cnt(struct platform_device *pdev) goto failed_regulator; } } else { + if (PTR_ERR(fep->reg_phy) == -EPROBE_DEFER) { + ret = -EPROBE_DEFER; + goto failed_regulator; + } fep->reg_phy = NULL; }
Defer probe if regulator is not ready. E.g. some regulator is fixed regulator controlled by i2c expander gpio, the i2c device may be probed after the driver, then it should handle the case of defer probe error. Signed-off-by: Fugang Duan <fugang.duan@nxp.com> --- drivers/net/ethernet/freescale/fec_main.c | 4 ++++ 1 file changed, 4 insertions(+)