Patchwork [U-Boot] corenet_ds: pick the middle value for all tested timing parameters

login
register
mail settings
Submitter Kumar Gala
Date March 5, 2011, 4:13 p.m.
Message ID <1299341597-20276-1-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/85534/
State Accepted
Commit 59a4089f82979d8cf24fa3ec39ea5d9cf2f42bb0
Delegated to: Kumar Gala
Headers show

Comments

Kumar Gala - March 5, 2011, 4:13 p.m.
From: York Sun <yorksun@freescale.com>

For DDR3 controller, the clk_adjust and wrlvl_start are platform-dependent.
The best values should be picked up from the middle of all working
combinations. This patch updates the table with confirmed values tested on
Hynix dual-rank UDIMMs (HMT125U7BFR8C-H9) at 1300MT/s, 1200MT/s, 1000MT/s,
900MT/s, 800MT/s and Kingston quad-rank RDIMMs (KVR1333D3Q8R9S/4G) at 1300MT/s,
1200MT/s, 1000MT/s.

Signed-off-by: York Sun <yorksun@freescale.com>
---
 board/freescale/corenet_ds/ddr.c |   58 ++++++++++++--------------------------
 1 files changed, 18 insertions(+), 40 deletions(-)
Kumar Gala - March 7, 2011, 3:12 p.m.
On Mar 5, 2011, at 10:13 AM, Kumar Gala wrote:

> From: York Sun <yorksun@freescale.com>
> 
> For DDR3 controller, the clk_adjust and wrlvl_start are platform-dependent.
> The best values should be picked up from the middle of all working
> combinations. This patch updates the table with confirmed values tested on
> Hynix dual-rank UDIMMs (HMT125U7BFR8C-H9) at 1300MT/s, 1200MT/s, 1000MT/s,
> 900MT/s, 800MT/s and Kingston quad-rank RDIMMs (KVR1333D3Q8R9S/4G) at 1300MT/s,
> 1200MT/s, 1000MT/s.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> board/freescale/corenet_ds/ddr.c |   58 ++++++++++++--------------------------
> 1 files changed, 18 insertions(+), 40 deletions(-)

applied

- k

Patch

diff --git a/board/freescale/corenet_ds/ddr.c b/board/freescale/corenet_ds/ddr.c
index 6660b01..f8df9d1 100644
--- a/board/freescale/corenet_ds/ddr.c
+++ b/board/freescale/corenet_ds/ddr.c
@@ -170,27 +170,16 @@  const board_specific_parameters_t board_specific_parameters[][30] = {
 	 *  lo|  hi|  num|  clk| wrlvl | cpo  |wrdata|2T
 	 * mhz| mhz|ranks|adjst| start | delay|
 	 */
-		{  0, 333,    4,    5,     7,   0xff,    2,  0},
-		{334, 400,    4,    5,     7,   0xff,    2,  0},
-		{401, 549,    4,    5,     7,   0xff,    2,  0},
-		{550, 680,    4,    5,     7,   0xff,    2,  0},
-		{681, 850,    4,    5,     7,   0xff,    2,  0},
-		{851, 1050,   4,    5,     7,   0xff,    2,  0},
-		{1051, 1250,  4,    5,     8,   0xff,    2,  0},
-		{1251, 1350,  4,    5,     9,   0xff,    2,  0},
-		{  0, 333,    2,    5,     7,   0xff,    2,  0},
-		{334, 400,    2,    5,     7,   0xff,    2,  0},
-		{401, 549,    2,    5,     7,   0xff,    2,  0},
-		{550, 680,    2,    5,     7,   0xff,    2,  0},
-		{681, 850,    2,    5,     7,   0xff,    2,  0},
-		{851, 1050,   2,    5,     7,   0xff,    2,  0},
-		{1051, 1250,  2,    5,     7,   0xff,    2,  0},
+		{  0, 850,    4,    1,     5,   0xff,    2,  0},
+		{851, 950,    4,    3,     5,   0xff,    2,  0},
+		{951, 1050,   4,    5,     8,   0xff,    2,  0},
+		{1051, 1250,  4,    5,    10,   0xff,    2,  0},
+		{1251, 1350,  4,    5,    11,   0xff,    2,  0},
+		{  0, 850,    2,    5,     6,   0xff,    2,  0},
+		{851, 950,    2,    5,     7,   0xff,    2,  0},
+		{951, 1050,   2,    5,     7,   0xff,    2,  0},
+		{1051, 1250,  2,    4,     6,   0xff,    2,  0},
 		{1251, 1350,  2,    5,     7,   0xff,    2,  0},
-		{  0, 333,    1,    5,     7,   0xff,    2,  0},
-		{334, 400,    1,    5,     7,   0xff,    2,  0},
-		{401, 549,    1,    5,     7,   0xff,    2,  0},
-		{550, 680,    1,    5,     7,   0xff,    2,  0},
-		{681, 850,    1,    5,     7,   0xff,    2,  0}
 	},
 
 	{
@@ -199,27 +188,16 @@  const board_specific_parameters_t board_specific_parameters[][30] = {
 	 *  lo|  hi|  num|  clk| wrlvl | cpo  |wrdata|2T
 	 * mhz| mhz|ranks|adjst| start | delay|
 	 */
-		{  0, 333,    4,    5,     7,   0xff,    2,  0},
-		{334, 400,    4,    5,     7,   0xff,    2,  0},
-		{401, 549,    4,    5,     7,   0xff,    2,  0},
-		{550, 680,    4,    5,     7,   0xff,    2,  0},
-		{681, 850,    4,    5,     7,   0xff,    2,  0},
-		{851, 1050,   4,    5,     7,   0xff,    2,  0},
-		{1051, 1250,  4,    5,     8,   0xff,    2,  0},
-		{1251, 1350,  4,    5,     9,   0xff,    2,  0},
-		{  0, 333,    2,    5,     7,   0xff,    2,  0},
-		{334, 400,    2,    5,     7,   0xff,    2,  0},
-		{401, 549,    2,    5,     7,   0xff,    2,  0},
-		{550, 680,    2,    5,     7,   0xff,    2,  0},
-		{681, 850,    2,    5,     7,   0xff,    2,  0},
-		{851, 1050,   2,    5,     7,   0xff,    2,  0},
-		{1051, 1250,  2,    5,     7,   0xff,    2,  0},
+		{  0, 850,    4,    1,     5,   0xff,    2,  0},
+		{851, 950,    4,    3,     5,   0xff,    2,  0},
+		{951, 1050,   4,    5,     8,   0xff,    2,  0},
+		{1051, 1250,  4,    5,    10,   0xff,    2,  0},
+		{1251, 1350,  4,    5,    11,   0xff,    2,  0},
+		{  0, 850,    2,    5,     6,   0xff,    2,  0},
+		{851, 950,    2,    5,     7,   0xff,    2,  0},
+		{951, 1050,   2,    5,     7,   0xff,    2,  0},
+		{1051, 1250,  2,    4,     6,   0xff,    2,  0},
 		{1251, 1350,  2,    5,     7,   0xff,    2,  0},
-		{  0, 333,    1,    5,     7,   0xff,    2,  0},
-		{334, 400,    1,    5,     7,   0xff,    2,  0},
-		{401, 549,    1,    5,     7,   0xff,    2,  0},
-		{550, 680,    1,    5,     7,   0xff,    2,  0},
-		{681, 850,    1,    5,     7,   0xff,    2,  0}
 	}
 };