[hurd,commited] hurd: Fix support/support_enter_mount_namespace.c build

Message ID 20180103235533.23247-1-samuel.thibault@ens-lyon.org
State New
Headers show
Series
  • [hurd,commited] hurd: Fix support/support_enter_mount_namespace.c build
Related show

Commit Message

Samuel Thibault Jan. 3, 2018, 11:55 p.m.
* support/support_enter_mount_namespace.c [!CLONE_NEWNS]: Do not
	include <sys/mount.h>.
---
 ChangeLog                               | 5 +++++
 support/support_enter_mount_namespace.c | 2 ++
 2 files changed, 7 insertions(+)

Comments

Joseph Myers Jan. 4, 2018, 1:30 p.m. | #1
On Thu, 4 Jan 2018, Samuel Thibault wrote:

> +#ifdef CLONE_NEWNS
>  #include <sys/mount.h>
> +#endif /* CLONE_NEWNS */

We use preprocessor indentation inside #if, so making a #include 
conditional requires changing it to "# include", and likewise when making 
any other preprocessor directives conditional (other than when the outer 
#if is a header's multiple-include guard).

Patch

diff --git a/ChangeLog b/ChangeLog
index 68b8c93ccc..40e4d1b4eb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-01-03  Samuel Thibault  <samuel.thibault@ens-lyon.org>
+
+	* support/support_enter_mount_namespace.c [!CLONE_NEWNS]: Do not
+	include <sys/mount.h>.
+
 2018-01-02  Wilco Dijkstra  <wdijkstr@arm.com>
 
 	* math/math.h (math_errhandling): Set to 0 with __FAST_MATH__.
diff --git a/support/support_enter_mount_namespace.c b/support/support_enter_mount_namespace.c
index 64fe08b044..3b4ce84f35 100644
--- a/support/support_enter_mount_namespace.c
+++ b/support/support_enter_mount_namespace.c
@@ -20,7 +20,9 @@ 
 
 #include <sched.h>
 #include <stdio.h>
+#ifdef CLONE_NEWNS
 #include <sys/mount.h>
+#endif /* CLONE_NEWNS */
 
 bool
 support_enter_mount_namespace (void)