| Message ID | 20180103152346.22672-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 368e86d9836aa044f2afb233e0445c8e4040b179 |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot,1/1] configs: x86: allow to override CONFIG_BOOTCOMMAND | expand |
On Wed, Jan 3, 2018 at 11:23 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > Allow to override CONFIG_BOOTCOMMAND in .config. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > include/configs/x86-common.h | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hi Heinrich, On 3 January 2018 at 08:23, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > Allow to override CONFIG_BOOTCOMMAND in .config. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > include/configs/x86-common.h | 2 ++ > 1 file changed, 2 insertions(+) This is a Chrome OS boot line. I think you should consider whether it should move into x86-chromebook.h or similar? Then you can just remove it from the common file. Regards, Simon
On 01/08/2018 05:50 AM, Simon Glass wrote: > Hi Heinrich, > > On 3 January 2018 at 08:23, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >> Allow to override CONFIG_BOOTCOMMAND in .config. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> include/configs/x86-common.h | 2 ++ >> 1 file changed, 2 insertions(+) > > This is a Chrome OS boot line. I think you should consider whether it > should move into x86-chromebook.h or similar? Then you can just remove > it from the common file. I understand Chromebooks uses this boot line. theadorable-x86-common.h undefines CONFIG_BOOTCOMMAND anyway. For qemu I need to override the value. What about all the other x86 boards? They seem to have bootargs matching the CONFIG_BOOTCOMMAND. As they are not using distro boot, wouldn't removing the CONFIG_BOOTCOMMAND default value create havoc? As a downstream user I would not cherish such a change. I think it is safer to leave the default value where it is. Would you accept the patch as is? Best regards Heinrich
Hi Heinrich, On 8 January 2018 at 13:57, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > On 01/08/2018 05:50 AM, Simon Glass wrote: >> >> Hi Heinrich, >> >> On 3 January 2018 at 08:23, Heinrich Schuchardt <xypron.glpk@gmx.de> >> wrote: >>> >>> Allow to override CONFIG_BOOTCOMMAND in .config. >>> >>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >>> --- >>> include/configs/x86-common.h | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> >> This is a Chrome OS boot line. I think you should consider whether it >> should move into x86-chromebook.h or similar? Then you can just remove >> it from the common file. > > > I understand Chromebooks uses this boot line. > > theadorable-x86-common.h undefines CONFIG_BOOTCOMMAND anyway. > For qemu I need to override the value. > > What about all the other x86 boards? > They seem to have bootargs matching the CONFIG_BOOTCOMMAND. > > As they are not using distro boot, wouldn't removing the CONFIG_BOOTCOMMAND > default value create havoc? > As a downstream user I would not cherish such a change. > > I think it is safer to leave the default value where it is. > > Would you accept the patch as is? Bin seems happy and I have no objection. Regards, Simon
On Mon, Jan 8, 2018 at 11:10 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Wed, Jan 3, 2018 at 11:23 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >> Allow to override CONFIG_BOOTCOMMAND in .config. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> include/configs/x86-common.h | 2 ++ >> 1 file changed, 2 insertions(+) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h index 064c546403..3d536dc9d5 100644 --- a/include/configs/x86-common.h +++ b/include/configs/x86-common.h @@ -64,8 +64,10 @@ * Command line configuration. */ +#ifndef CONFIG_BOOTCOMMAND #define CONFIG_BOOTCOMMAND \ "ext2load scsi 0:3 01000000 /boot/vmlinuz; zboot 01000000" +#endif #if defined(CONFIG_CMD_KGDB) #define CONFIG_KGDB_BAUDRATE 115200
Allow to override CONFIG_BOOTCOMMAND in .config. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- include/configs/x86-common.h | 2 ++ 1 file changed, 2 insertions(+)